Bug 179637 - [patch] ports-mgmt/portupdate-scan: add the "-a [date]" option
Summary: [patch] ports-mgmt/portupdate-scan: add the "-a [date]" option
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 17:30 UTC by Marcel Bonnet
Modified: 2014-06-05 07:31 UTC (History)
2 users (show)

See Also:

Attachments
file.diff (1.67 KB, patch)
2013-06-17 17:30 UTC, Marcel Bonnet 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Bonnet 2013-06-17 17:30:01 UTC 
The simple patch above adds the "-a [date]" option, limiting the affected ports list between the informed date and the last UPDATING entry.
Comment 1 Mark Linimon 2013-06-17 19:25:08 UTC 
to which port does this PR apply?
Comment 2 Marcel Bonnet 2013-06-18 14:01:46 UTC 
On 17 June 2013 15:25, Mark Linimon <linimon@lonesome.com> wrote:

> to which port does this PR apply?
>

I'm sorry, it applies to: ports-mgmt/portupdate-scan

thanks.
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-18 20:07:48 UTC 
Maintainer of ports-mgmt/portupdate-scan,

Please note that PR ports/179637 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179637

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-18 20:07:49 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 5 alex 2013-06-19 00:20:06 UTC 
On Tue, Jun 18, 2013 at 07:07:48PM +0000, Edwin Groothuis wrote:
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

I basically agree with this patch, but would like to see changes
made to address a few issues:

1. Need to bump the version # in the Makefile.
2. Spacing inconsistent with existing code and extra space in usage line.
3. Instead of 3 lines to immediately exit, it'd be shorter and cleaner
   to use:
   last if $res <= $afterDate;

Should I submit an alternate patch?

Alex
Comment 6 Jonathan Chu freebsd_committer freebsd_triage 2014-06-04 15:54:31 UTC 
This PR looks quite old. Alex, do you still want to address this?
Comment 7 alex 2014-06-04 22:40:45 UTC 
> This PR looks quite old. Alex, do you still want to address this?

This PR can be closed since this feature was included as part of PR 190051, which you just committed.

Alex
Comment 8 Jonathan Chu freebsd_committer freebsd_triage 2014-06-05 07:31:30 UTC 
Included in PR 190051