Bug 180668 - [ maintainer ] japanese/mutt-devel update to 1.5.21-ja.2
Summary: [ maintainer ] japanese/mutt-devel update to 1.5.21-ja.2
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-20 07:20 UTC by SHIOZAKI Takehiko
Modified: 2014-10-05 22:01 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (264.20 KB, patch)
2013-07-20 07:20 UTC, SHIOZAKI Takehiko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SHIOZAKI Takehiko 2013-07-20 07:20:00 UTC 
	- Updated to 1.5.21-ja.2
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-26 23:36:59 UTC 
I'm looking at this patch and I see some strange things

1) Lots of comments added to the header.  This is not conventional.  Maybe in the middle of the makefile, but not at the top.  I'm sure you can find other examples but I'm not sure they are smiled upon.

2) COMMENT= changed to COMMENT?= but not clear why.  Also comment starts with word "The" but that's not allowed

3) same with MAINTAINER?=

4) why this?
DISTFILES=	${DISTNAME}${EXTRACT_SUFX}
EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX}

Aren't those the defaults?  Then I see those augmented later on future lines, but it's not clear why.


Is this supposed to be MASTER port?

5) Does the patch still apply?

6) Has it been tested in poudriere, redports, etc?
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-05 22:01:51 UTC 
No feedback on this old PR, so I'm closing it.