Bug 181004 - options: ftp/curl fails to compile out of the box when WITHOUT_GSSAPI specified in the base system
Summary: options: ftp/curl fails to compile out of the box when WITHOUT_GSSAPI specifi...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-03 18:40 UTC by Enji Cooper
Modified: 2018-01-12 06:47 UTC (History)
5 users (show)

See Also:

Attachments
svn diff for ftp/curl (4.17 KB, patch)
2015-04-20 10:00 UTC, Bernard Spil 		no flags Details | Diff
svn diff for ftp/curl (3.63 KB, patch)
2015-04-20 12:25 UTC, Bernard Spil 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2013-08-03 18:40:00 UTC 
ftp/curl sets ./configure knobs based on the options passed to the port, and the port was changed to options-NG, which means it no longer uses the knobs in the base system as defaults.

Some knobs really should have sane defaults based on the base system knobs, in particular:

NOPORTDOCS -> ${MK_DOCS} != "no"
NOPORTEXAMPLES -> ${MK_EXAMPLES} != "no"

GSSAPI -> ${MK_GSSAPI} != "no"
IPV6 -> ${MK_INET6} != "no"

etc.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-03 18:40:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-02 19:25:39 UTC 
Responsible Changed
From-To: sunpoet->portmgr

options framework is portmgr territory.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-06-02 02:43:17 UTC 
Infrastructure PR.
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2014-08-04 12:06:24 UTC 
I completly disagree here, the ports cannot have a knowledge of what options has been passed when building the base system, ports are being built on a system which can have been built somewhere else.

live detection of what is or is not present on the base system might be interesting in particular concerning ipv6 or friends, if done this is supposed to work in chroot and jails as well!
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2015-04-20 10:00:30 UTC 
Created attachment 155762 [details]
svn diff for ftp/curl

This patch fixes the WITHOUT_GSSAPI builds.

Additionally makes the port correctly conflict ports' OpenSSL with base GSSAPI.

Reorder checks alphabetically
Comment 6 Bernard Spil freebsd_committer freebsd_triage 2015-04-20 12:25:30 UTC 
Created attachment 155768 [details]
svn diff for ftp/curl

Improved pervious patch
curl would still link kerberos when both --with-gssapi= and --without-gssapi were passed to configure. This works in the various configurations I've tested.
Comment 7 Bernard Spil freebsd_committer freebsd_triage 2015-04-20 12:30:03 UTC 
The documentation is quite confusing for gssapi, 
1. Porter's Handbook specifies GSSAPI_NONE
2. bsd.options.desc.mk contains GSSAPI= GSSAPI Security API support marking it as a "standard" option
3. Uses/gssapi.mk also specifies GSSAPI_NONE but fails to mention how to handle WITHOUT_GSSAPI/OPTIONS_UNSET+=GSSAPI
Comment 8 Don Lewis freebsd_committer freebsd_triage 2015-05-31 22:09:56 UTC 
(In reply to Bernard Spil from comment #6)

For a better OPENSSL vs. GSSAPI_BASE sanity check, see <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200555>
Comment 9 Walter Schwarzenfeld 2018-01-12 03:42:49 UTC 
Is this still relevant?
Comment 10 Don Lewis freebsd_committer freebsd_triage 2018-01-12 06:47:35 UTC 
This can probably be closed since the port can now has GSSAPI_HEIMDAL, GSSAPI_MIT, and GSSAPI_NONE options so that it can build if GSSAPI is disabled in base.