* FreeBSD Port sysutils/bacula-client and "killall" in pkg-plist.client *

Upgrading bacula-client on a jail server running jails with other bacula-client processes ("bacula-fd") kills all bacula-cient processes. They do not get restartet afer upgrading..


$cat /usr/ports/sysutils/bacula-server/pkg-plist.client

lib/libbac.la
lib/libbac.so
lib/libbac.so.%%MAJOR%%
lib/libbaccfg.la
lib/libbaccfg.so
lib/libbaccfg.so.%%MAJOR%%
lib/libbacfind.la
lib/libbacfind.so
lib/libbacfind.so.%%MAJOR%%
lib/libbacpy.la
lib/libbacpy.so
lib/libbacpy.so.%%MAJOR%%
lib/bpipe-fd.so
sbin/bacula-fd
sbin/bconsole
@unexec /usr/bin/killall bacula-fd > /dev/null 2>&1 || true
@exec mkdir -p %%BACULA_DIR%%
@dirrmtry %%BACULA_DIR%%
@dirrmtry share/bacula

Here you are using "@unexec /usr/bin/killall bacula-fd > /dev/null 2>&1 || true"

I maintain some multijail-servers hosting about 50 jails per server and I have bacula-client running on the jail-host itself and also inside on a great part of the jails (because this makes it easier for me to relocate jails to different jail-hosts and not having to worry that they are actually being backepd up, also because bacula-server becomes unusable slow when restoring to a bacula-client hosting millions of files or many jails - I guess database limitations.)

If I do a pkg upgrade of bacula-client on the jail-host, "killall" is killing all running bacula-fd processes on the jailhost, also the bacula-fd processes inside all of the jails.

Fix: I  propose the following patch for pkg-plist.client:



This of course makes the assumption that there is bacula-fd .pid file in /var/run

Looking at /usr/local/etc/bacula-fd.conf.sample I assume it is the common case that users have
"Pid Directory = /var/run" confuigured into bacula-fd.conf

The more universal solution would be to come up with a short script that a) uses pkill for killing purposes  b) checks if it is running inside or outside a jail (sysctl) c) makes sure pkill only shoots down the wanted bacula-fd process inside (jailed) or outside (host).

Besides: Why not use the bacula rc script in /usr/local/etc/rc.d/ for stopping/starting bacula-client?
I think this could be achieved by using "@stopdaemon bacula-fd" in pkg-plist.client

I'd favour a solution where portupgrade stops bacula-fd by using the rc script, upgrades the port and then starts bacula-fd (also by rc script).--jLe9faT1604tANq5bnSFjZDW8DgxS3i8NmF3f7rfnLyf0eSp
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- pkg-plist.client	2012-12-16 17:32:45.000000000 +0100
+++ pkg-plist.client.patched	2013-07-08 11:25:05.092088611 +0200
@@ -13,7 +13,7 @@
lib/bpipe-fd.so
sbin/bacula-fd
sbin/bconsole
-@unexec /usr/bin/killall bacula-fd > /dev/null 2>&1 || true
+@unexec kill `cat /var/run/bacula-fd*.pid` > /dev/null 2>&1 || true
@exec mkdir -p %%BACULA_DIR%%
@dirrmtry %%BACULA_DIR%%
@dirrmtry share/bacula
How-To-Repeat: Upgrade bacula-client on a jail-host running bacula-client inside hosted jails.