Bug 181324 - [patch] emulators/virtualbox-ose: fix integration with net/istgt option VBOXVD (VirtualBox virtual hd integration)
Summary: [patch] emulators/virtualbox-ose: fix integration with net/istgt option VBOXV...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-15 14:50 UTC by Martin Birgmeier
Modified: 2018-01-12 09:25 UTC (History)
4 users (show)

See Also:

Attachments
file.diff (624 bytes, patch)
2013-08-15 14:50 UTC, Martin Birgmeier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2013-08-15 14:50:00 UTC 
Compiling net/istgt with option VBOXHD requires a fix to a VirtualBox header file.

(I have verified that virtualbox-ose itself still compiles.)

Fix: See attached patch.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-15 14:50:07 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-15 14:50:07 UTC 
Maintainer of net/istgt,

Please note that PR ports/181324 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181324

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2014-05-06 16:13:36 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 4 William Grzybowski freebsd_committer freebsd_triage 2014-05-06 16:14:57 UTC 
Responsible Changed
From-To: wg->freebsd-ports-bugs

My mistake, back to the pool
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-07 14:57:48 UTC 
Hi, if you are still interested in having this port in FreeBSD, it may (or may not) need to be reworked to support stage, and it may need updating to other newer conventions such as "USES" which is expanding all time.
For staging, see http://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-May/000080.html


Additionally, you need to provide some sort of quality assurance.    
In order of preference, we are looking for:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) at least this: https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html

Please provide an updated shar file and attach a test log.  Alternatively, please indicate if you are no longer interested in having this software in the Ports Collection and that we can close the PR.

Thanks!
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-10 07:31:04 UTC 
my mistake, that form message was meant only for "[new port]" PRs.  I'll take this.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-10 07:38:51 UTC 
This was a badly written title. :)
Okay, this is a vbox PR.  I'm going to reassign the PR to vbox@
Comment 8 Martin Birgmeier 2014-08-10 13:57:26 UTC 
The (third) patch proposed by Dan Lukes in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=179989 might be better than mine - the vbox people should decide.

-- Martin
Comment 9 Martin Birgmeier 2016-11-03 19:18:01 UTC 
I don't use this patch any more. Please close it.
Comment 10 Walter Schwarzenfeld freebsd_triage 2018-01-12 03:50:30 UTC 
Forgotten to close. See comment9.