Bug 181729 - [patch] japanese/skkserv: provide default for skkserv_enable
Summary: [patch] japanese/skkserv: provide default for skkserv_enable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 20:10 UTC by Tijl Coosemans
Modified: 2013-12-03 15:10 UTC (History)
0 users

See Also:

Attachments
skkserv.patch (778 bytes, patch)
2013-09-01 20:10 UTC, Tijl Coosemans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2013-09-01 20:10:00 UTC 
There's a warning during boot if skkserv_enable isn't defined.
The attached patch provides a default value like other port provided
rc.d scripts do.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-01 20:10:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->hrs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-12-03 15:05:25 UTC 
Author: tijl
Date: Tue Dec  3 15:05:17 2013
New Revision: 335572
URL: http://svnweb.freebsd.org/changeset/ports/335572

Log:
  There's a warning during boot if the skkserv_enable rc variable is
  undefined so set it to "NO" by default.
  
  PR:		ports/181729
  Approved by:	maintainer timeout (3 months)

Modified:
  head/japanese/skkserv/Makefile
  head/japanese/skkserv/files/skkserv.in

Modified: head/japanese/skkserv/Makefile
==============================================================================
--- head/japanese/skkserv/Makefile	Tue Dec  3 14:52:52 2013	(r335571)
+++ head/japanese/skkserv/Makefile	Tue Dec  3 15:05:17 2013	(r335572)
@@ -3,7 +3,7 @@
 
 PORTNAME=	skkserv
 PORTVERSION=	9.6
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	japanese
 MASTER_SITES=	${MASTER_SITE_PORTS_JP}
 DISTNAME=	skk${PORTVERSION}

Modified: head/japanese/skkserv/files/skkserv.in
==============================================================================
--- head/japanese/skkserv/files/skkserv.in	Tue Dec  3 14:52:52 2013	(r335571)
+++ head/japanese/skkserv/files/skkserv.in	Tue Dec  3 15:05:17 2013	(r335572)
@@ -12,6 +12,7 @@ name=skkserv
 rcvar=skkserv_enable
 command=%%PREFIX%%/sbin/skkserv
 
+: ${skkserv_enable:="NO"}
 : ${skkserv_flags:="-a 127.0.0.1 -u skkserv"}
 
 load_rc_config ${name}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2013-12-03 15:05:37 UTC 
State Changed
From-To: open->closed

Committed in r335572.