Bug 181988 - graphics/qiv: uses needs pkgconfig
Summary: graphics/qiv: uses needs pkgconfig
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-10 12:40 UTC by Kalten
Modified: 2013-09-12 03:40 UTC (History)
0 users

See Also:

Attachments
file.diff (228 bytes, patch)
2013-09-10 12:40 UTC, Kalten 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalten 2013-09-10 12:40:01 UTC 
I compile packages in ports-mgmt/poudriere.
``gmake: pkg-config: Command not found''
and some resulting errors.
(does not occur when directly compiling via ``make'')

Fix: Add ``pkgconfig'' to ``USES='' in Makefile.
(see attached patch-file)

Patch attached with submission follows:
How-To-Repeat: Use ports-mgmt/poudriere to build the package.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-09-11 00:59:50 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2013-09-11 07:19:05 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-09-12 03:37:30 UTC 
Author: jgh
Date: Thu Sep 12 02:37:17 2013
New Revision: 327030
URL: http://svnweb.freebsd.org/changeset/ports/327030

Log:
  Note: pr originally was intended to only address pkgconfig dependency,
  however this was addressed in rr327018
  
  - adopt new lib_depends format
  - pet portlint
  - move pre-configure to post-patch-script
  
  PR:		181988
  Submitted by:	kalten@gmx.at

Modified:
  head/graphics/qiv/Makefile

Modified: head/graphics/qiv/Makefile
==============================================================================
--- head/graphics/qiv/Makefile	Thu Sep 12 01:40:42 2013	(r327029)
+++ head/graphics/qiv/Makefile	Thu Sep 12 02:37:17 2013	(r327030)
@@ -12,14 +12,13 @@ EXTRACT_SUFX=	.tgz
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Small, fast GDK/Imlib2 image viewer
 
-LIB_DEPENDS=	Imlib2.5:${PORTSDIR}/graphics/imlib2
-
 LICENSE=	GPLv2
 
+LIB_DEPENDS=	libImlib2.so:${PORTSDIR}/graphics/imlib2
+
 USES=		gmake pkgconfig
 USE_GNOME=	gtk20
 
-
 OPTIONS_DEFINE=	XINERAMA
 
 MAN1=		qiv.1
@@ -28,7 +27,7 @@ USE_XORG+=	x11
 
 .include <bsd.port.options.mk>
 
-pre-configure:
+post-patch-script:
 .if ${PORT_OPTIONS:MXINERAMA}
 USE_XORG+=	xinerama
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2013-09-12 03:37:45 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!