Control-something shortcuts does not work on applications which built with x11-toolkits/fltk 1.3.2 (ex. net/tigervnc). This bug was already fixed at upstream later snapshot. See also: ports/181345 Discussion at Arch Linux bugtracker: https://bugs.archlinux.org/task/36186 https://bbs.archlinux.org/viewtopic.php?id=166735 Fix: Either A or B can fix the issue. A. Apply the patch to current portversion of x11-toolkits/fltk B. Update x11-toolkits/fltk to 1.3.x latest snapshot After updating x11-toolkits/fltk, bump PORTREVISION of net/tigervnc or commit ports/180911. Of course, all other ports which depends on x11-toolkits/fltk needs bumping PORTREVISION. How-To-Repeat: 1. Install net/tigervnc with VIEWER option enabled 2. Connect to remote vnc session by tigervnc's vncviewer 3. open xterm 4. Ctrl-C, Ctrl-D does not work
Responsible Changed From-To: freebsd-ports-bugs->gahr Over to maintainer (via the GNATS Auto Assign Tool)
This patch is for plan A. Tested by me, tigervnc viewer functionally works. I also asked the submitter of ports/181345 to test my patch. I will report later. Successfully built on redports[1]. Changeset can be seen on on my redports repo[2]. [1] https://redports.org/buildarchive/20130911051101-57374/ [2] https://redports.org/changeset?reponame=&new=16794%40meta%2Fx11-toolkits%2Ffltk&old=14889%40meta%2Fx11-toolkits%2Ffltk -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
Thanks for your report. Would you please elaborate on your patch patch-00-tigervnc generated by the patch attached to this PR? Is it supposed to be applied again in fltk? I see it touches CMakeLists.txt, but the fltk port currently doesn't use CMake for building. Also, could you give me a pointer to where the issue was fixed upstream? -- Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp
On Wed, Sep 11, 2013 at 10:29:59AM +0200, Pietro Cerutti wrote: > Thanks for your report. Would you please elaborate on your patch > patch-00-tigervnc generated by the patch attached to this PR? patch-00-tigervnc, contains following 9 patches, is based on tigervnc.patch found at FS#36186 - Arch Linux tracker. - fltk-1_v4.3.x-keyboard-x11.patch - fltk-1.3.x-clipboard.patch - fltk-1_v5.3.x-clipboard-x11.patch - pixmap_v2.patch - fltk-1_v5.3.x-cursor.patch - fltk-1_v2.3.0-modal.patch - fltk-1_v3.3.0-icons.patch - fltk-1.3.x-screen_num.patch - fltk-1_v3.3.x-multihead.patch 00 in filename manages patching order in order to apply patch-src_Fl_x.cxx after patch-00-tigervnc. > Is it supposed to be applied again in fltk? I see it touches > CMakeLists.txt, but the fltk port currently doesn't use CMake for > building. CMakeList.txt is touched by fltk-1_v5.3.x-cursor.patch. If fltk port does not use cmake, we can remove patch for CMakeList.txt. > Also, could you give me a pointer to where the issue was fixed > upstream? I was wrong. The issue haven't been fixed yet. So fltk needs to be patched locally by each distributor until fixed upstream. For example, Fedora does. > add some not-yet-accepted patches needed by tigervnc http://pkgs.fedoraproject.org/cgit/fltk.git/commit/?id=5e945f709b69bce1ffb4928f7fc0cc7fe9d7a02c http://pkgs.fedoraproject.org/cgit/fltk.git/ My patch is based on discussion on Arch Linux tracker. But Fedora describes the issue more clearly. net/tigervnc requires fltk to be patched some not-yet-accepted patches. -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
Thanks for the clarification. The last post at [1] says that fltk-snapshot is fixed. I'm not really comfortable with including this large patchset in the stable fltk. What about creating a separate fltk-devel port instead and track snapshots from there? [1] https://bbs.archlinux.org/viewtopic.php?id=166735 -- Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp
Sorry for delayed response. I wasn't aware of your reply. Please CC me. I never miss your reply! I agree with your idea. But I am worried about conflict between fltk and fltk-devel if net/tigervnc and textproc/fldiff are installed at the same time, for example. If that is not a problem, creating fltk-devel sounds good for me. -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
I tested your patch but it still doesn't work. I realized that hasn't fixed at upstream. Fixed at fltk-snapshot you mentioned means fixed at arch linux's fltk-snapshot package. Arch linux patches the snapshot. See the tarball can be found at [1]. We still have to patch fltk-devel. [1] https://aur.archlinux.org/packages/fltk-snapshot/?setlang=en -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
I see archlinux is somehow lagging behind (r9701, while our devel port is at r9998). I don't have the time right now to adapt their patch to the new snapshot, nor do I have the resources (read: VNC server) to test tigervnc with the patched fltk-devel. Could you please take care of providing a patch that I can include in files/? Thanks! -- Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp
I'm working on that. -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
It is very difficult to apply patches to latest fltk snapshot. Either port fltk or fltk-devel, we need to apply patches. I know that you are not comfortable to apply patches to stable fltk. Then, is it possible making a new patched port based on stable version of fltk rather than applying patches to latest snapshot? I think it is easiest solution. -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
Waiting for upstream fix. -- `whois vmeta.jp | nkf -w` meta <meta@vmeta.jp>
Is this PR still valid?
Reported to upstream and upstream developers working on the issue.
Do you have a pointer to the upstream bug report or something?
I don't have explicit pointer but these discussions in mailing list can describe. https://www.mail-archive.com/tigervnc-devel@lists.sourceforge.net/msg02740.html https://www.mail-archive.com/tigervnc-users%40lists.sourceforge.net/msg00744.html Background of this bug is TigerVNC project uses tigervnc-patched fltk toolkit. We have original FLTK toolkit (stable release and latest snapshot) in out ports tree. I'm waiting for upstream tigervnc developers merge their patches to upstream-upstream (fltk). Upstream to upstream-upstream status is: > Just an FYI; most of the patches we require for FLTK ar now merged > upstream. The keyboard hacks remain, but I need to explore alternatives > there first. The remained "keyboard hacks" covers this Bug 182006.
I think this bug can be closed because there's nothing to do with x11-toolkits/fltk, the stable release of fltk. When "keyboard hacks" patches merged upstream-upstream and be available at latest snapshot, I'm going to have net/tigervnc to switch to x11-toolkits/fltk-devel instead of x11-toolkits/fltk. Would you like to close this bug 182006 and keep bug 181345 open?
Closed as "Report to Upstream".
*** Bug 181345 has been marked as a duplicate of this bug. ***