Bug 182460 - New port: multimedia/qwinff Qt4 media converter GUI
Summary: New port: multimedia/qwinff Qt4 media converter GUI
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-28 16:10 UTC by Che-Huai Lin
Modified: 2014-08-07 14:34 UTC (History)
1 user (show)

See Also:


Attachments
file.shar (3.96 KB, text/plain)
2013-09-28 16:10 UTC, Che-Huai Lin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Che-Huai Lin 2013-09-28 16:10:00 UTC
Graphical media converter based on FFmpeg and Qt4
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2014-02-03 20:51:09 UTC
State Changed
From-To: open->feedback

Build fails: 

===>  Configuring for qwinff-0.1.9 ===>  Building for qwinff-0.1.9 
gmake[1]: Wejcie do katalogu 
`/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9' cd 
/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/src && qmake-qt4 
DESTDIR=/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/bin 
OBJECTS_DIR=/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/build/obj 
MOC_DIR=/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/build/moc 
RCC_DIR=/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/build/rcc 
UI_DIR=/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/build/ui 
DEFINES+=QT_NO_DEBUG_OUTPUT CONFIG+=libnotify qwinff.pro && 
DATA_PATH=\"/usr/local/share/qwinff\" VERSION_ID_STRING=\"\" 
make make[2]: don't know how to make w. Stop 

make[2]: stopped in 
/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9/src gmake[1]: *** 
[release] Bd 2 gmake[1]: Opuszczenie katalogu 
`/usr/local/ports/multimedia/qwinff/work/qwinff-0.1.9' *** Error code 1 

Stop.  make: stopped in /usr/local/ports/multimedia/qwinff 

Enter the reason for changing this PR's state here. GNATS: Lines 
beginning with "GNATS:" will be deleted.
Comment 2 timothy.lin1 2014-02-05 15:37:43 UTC
The problem is in qwinff-0.1.9/Makefile. When recursively call make,
"$(MAKE)" should be used instead of "make".
Fix:
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#    qwinff
#    qwinff/files
#    qwinff/files/patch-Makefile
#    qwinff/Makefile
#    qwinff/pkg-descr
#    qwinff/pkg-plist
#    qwinff/distinfo
#
echo c - qwinff
mkdir -p qwinff > /dev/null 2>&1
echo c - qwinff/files
mkdir -p qwinff/files > /dev/null 2>&1
echo x - qwinff/files/patch-Makefile
sed 's/^X//' >qwinff/files/patch-Makefile <<
'365342c9effe5a3ac7b078c4c6665d22'
X--- Makefile.orig    2014-02-05 10:18:59.000000000 +0800
X+++ Makefile    2014-02-05 10:16:51.000000000 +0800
X@@ -3,7 +3,7 @@
X # You can change these parameters to customize the build.
X
X # Installation Prefix
X-PREFIX=/usr
X+PREFIX?=/usr
X # Version ID String (displayed after the version string in the about
dialog)
X VIDSTR=
X
X@@ -39,8 +39,10 @@
X     QMAKE_DEFS += CONFIG+=libnotify
X endif
X
X+all: release
X+
X release:
X-    +cd $(SRC_DIR) && $(QMAKE) $(QMAKE_DEFS) qwinff.pro && $(DEFS) make
X+    +cd $(SRC_DIR) && $(QMAKE) $(QMAKE_DEFS) qwinff.pro && $(DEFS) $(MAKE)
X     -cd src && $(LRELEASE) qwinff.pro
X
X check:
X@@ -49,7 +51,7 @@
X clean:
X     rm -rf $(BIN_DIR)/*
X     rm -rf $(BUILD_DIR)/*
X-    -cd $(SRC_DIR) && make clean && rm Makefile
X+    -cd $(SRC_DIR) && $(MAKE) clean && rm Makefile
X
X install:
X     -install -d $(DESTDIR)$(PREFIX)/bin/
365342c9effe5a3ac7b078c4c6665d22
echo x - qwinff/Makefile
sed 's/^X//' >qwinff/Makefile << 'c08ba676b48ee0a32d696979ab1c3ae7'
X# Created by: Che-Huai Lin <lzh9102@gmail.com>
X# $FreeBSD$
X
XPORTNAME=    qwinff
XPORTVERSION=    0.1.9
XCATEGORIES=    multimedia audio kde
XMASTER_SITES=    SF/${PORTNAME}/release/v${PORTVERSION}
XDISTNAME= ${PORTNAME}_${PORTVERSION}
X
XMAINTAINER=    lzh9102@gmail.com
XCOMMENT=    Graphical media converter based on FFmpeg and Qt4
X
XBUILD_DEPENDS= pkg-config:${PORTSDIR}/devel/pkgconf
XRUN_DEPENDS=    ffmpeg:${PORTSDIR}/multimedia/ffmpeg \
X        sox:${PORTSDIR}/audio/sox
X
XMAKE_ARGS+= QMAKE=qmake-qt4 LRELEASE=lrelease-qt4
XUSE_QT4=    gui network dbus qmake_build moc_build rcc_build uic_build \
X        linguist_build
XUSE_BZIP2=    yes
XUSE_GMAKE=    yes
XINSTALLS_ICONS=    yes
XWRKSRC=   ${WRKDIR}/${PORTNAME}-${PORTVERSION}
X
XMAN1=        qwinff.1
XMANCOMPRESSED=    yes
X
XMAKE_JOBS_UNSAFE=    yes
X
X# options
XOPTIONS_DEFINE= LIBNOTIFY
XLIBNOTIFY_DESC= Send desktop notifications via libnotify
X
XOPTIONS_DEFAULT= LIBNOTIFY
X
X.include <bsd.port.options.mk>
X
X.if ${PORT_OPTIONS:MLIBNOTIFY}
XLIB_DEPENDS+= libnotify.so:${PORTSDIR}/devel/libnotify
XMAKE_ARGS+= USE_LIBNOTIFY=1
X.endif
X
X.include <bsd.port.mk>
c08ba676b48ee0a32d696979ab1c3ae7
echo x - qwinff/pkg-descr
sed 's/^X//' >qwinff/pkg-descr << '876adfa7a406951ee49fcb0740e2ba13'
XQWinFF is a GUI for [FFmpeg](http://ffmpeg.org), a powerful media
converter.
XFFmpeg can read audio and video files in various formats and convert
them into
Xother formats. QWinFF features an intuitive graphical interface and a
rich set
Xof presets to help you convert media files within a few clicks.
Advanced users
Xcan also adjust conversion parameters in detail.
X
XWWW: http://qwinff.github.io
876adfa7a406951ee49fcb0740e2ba13
echo x - qwinff/pkg-plist
sed 's/^X//' >qwinff/pkg-plist << 'e3f9d058d7047b6b5955aeb722dc7da2'
Xbin/qwinff
Xshare/applications/qwinff.desktop
Xshare/pixmaps/qwinff.png
X%%DATADIR%%/constants.xml
X%%DATADIR%%/presets.xml
X%%DATADIR%%/translations/qwinff_ar.qm  
X%%DATADIR%%/translations/qwinff_cs_CZ.qm
X%%DATADIR%%/translations/qwinff_de.qm  
X%%DATADIR%%/translations/qwinff_es_ES.qm
X%%DATADIR%%/translations/qwinff_es_GT.qm
X%%DATADIR%%/translations/qwinff_it_IT.qm
X%%DATADIR%%/translations/qwinff_ja_JP.qm
X%%DATADIR%%/translations/qwinff_ro_RO.qm
X%%DATADIR%%/translations/qwinff_ru.qm  
X%%DATADIR%%/translations/qwinff_tr_TR.qm
X%%DATADIR%%/translations/qwinff_zh_CN.qm
X%%DATADIR%%/translations/qwinff_zh_TW.qm
X@dirrm %%DATADIR%%/translations
X@dirrmtry %%DATADIR%%
X@dirrmtry share/pixmaps
X@dirrmtry share/applications
e3f9d058d7047b6b5955aeb722dc7da2
echo x - qwinff/distinfo
sed 's/^X//' >qwinff/distinfo << '4af759cf692112e66ebc43e314c8eec0'
XSHA256 (qwinff_0.1.9.tar.bz2) =
7f4fc35a13818bae796c8e25aeb7396c62f535ba79bde31c1641f862c455a6ed
XSIZE (qwinff_0.1.9.tar.bz2) = 463148
4af759cf692112e66ebc43e314c8eec0
exit
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2014-02-11 17:48:43 UTC
Thanks for update, for future reference please submit your updates as a
attachment. Submitting inline makes your shar file mangled, tabs are
converted to spaces, lines are wrapped etc.

Now port builds, but there are few things that need fixing:

1. New ports need to support staging
   https://wiki.freebsd.org/ports/StageDir

2. Port installs it's manpage to ${PREFIX}/share/man/man1 dir it should
   be ${PREFIX}/man/man1

3. Compilation must respect CFLAGS/CXXFLAGS set by user:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-cfla=
gs.html

--=20
pozdrawiam / with regards
Pawe=B3 P=EAkala
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-07 14:34:42 UTC
It looks like the submitter didn't pursue this, so closing.  I came to post this form letter in case he wants to reopen it:

=====================

Hi, if you are still interested in having this port in FreeBSD, it may (or may not) need to be reworked to support stage, and it may need updating to other newer conventions such as "USES" which is expanding all time.
For staging, see http://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-May/000080.html


Additionally, you need to provide some sort of quality assurance.    
In order of preference, we are looking for:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs

Please provide an updated shar file and attach a test log.  Alternatively, please indicate if you are no longer interested in having this software in the Ports Collection and that we can close the PR.

Thanks!