Bug 182493 - [PATCH] math/mpfr: Remove gratuitous DIST_SUBDIR
Summary: [PATCH] math/mpfr: Remove gratuitous DIST_SUBDIR
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-29 20:00 UTC by Craig Leres
Modified: 2013-10-03 19:10 UTC (History)
1 user (show)

See Also:

Attachments
patch.txt (695 bytes, text/plain)
2013-09-29 20:00 UTC, Craig Leres 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2013-09-29 20:00:00 UTC 
	math/mpfr forces the distfile to be stored in a subdirectory
	(which includes the PORTVERSION in its name); since only
	the one .tar.xz is needed to build the port it would be
	cleaner to use the default of /usr/ports/distfiles.

Fix: Please see the attached patch.
How-To-Repeat: 	fun 246 # ls -l /usr/ports/distfiles/mpfr-3.1.2
	total 1072
	-rw-r--r--  1 root  src  1074388 Mar 13  2013 mpfr-3.1.2.tar.xz
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-29 20:00:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alex Dupre freebsd_committer freebsd_triage 2013-10-03 15:04:53 UTC 
State Changed
From-To: open->closed

It's not gratuitous, all the patches are download in the same dir.
Comment 3 Craig Leres freebsd_committer freebsd_triage 2013-10-03 19:02:21 UTC 
I apologize for the flip subject line but I've never seen a port that
includes PORTVERSION in the DIST_SUBDIR. I guess there are some.

(There aren't any for the current PORTVERSION but) I would have expected
patches to be downloaded into /usr/ports/distfiles/mpfr and the
PORTVERSION prepended if the patch files names don't include what
version they're for.

		Craig