Bug 182596 - net/rsync: daemon needs additional option to start
Summary: net/rsync: daemon needs additional option to start
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-03 11:10 UTC by Alexey Markov
Modified: 2013-10-03 15:10 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Markov 2013-10-03 11:10:00 UTC 
After updating net/rsync port to the version 3.10 a rsyncd daemon looking for a config file at /etc/rsyncd.conf instead of /usr/local/etc/rsyncd.conf, so it needs an additional parameter rsyncd_flags="--config=/usr/local/etc/rsyncd.conf" in the /etc/rc.conf to start a rsyncd daemon.

How-To-Repeat: cd /usr/ports/net/rsync
make install clean
cat 'rsyncd_enable="YES"' >> /etc/rc.conf
/usr/local/etc/rc.d/rsyncd start

Starting rsyncd.
Failed to parse config file: /etc/rsyncd.conf
./rsyncd: WARNING: failed to start rsyncd
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-03 11:10:48 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2013-10-03 13:49:25 UTC 
It seems like 

CONFIGURE_ARGS= --disable-debug --enable-ipv6 \
                --with-rsyncd-conf=${PREFIX}/etc/rsyncd.conf

is completely ignored.

I will look into it, thanks.

Emanuel
Comment 3 Emanuel Haupt 2013-10-03 14:38:53 UTC 
The following patch seems to solve the problem:

--- patch begins here ---
Index: Makefile
===================================================================
--- Makefile    (revision 329172)
+++ Makefile    (working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=      rsync
 PORTVERSION=   3.1.0
+PORTREVISION=  1
 CATEGORIES=    net ipv6
 MASTER_SITES=  http://rsync.samba.org/ftp/%SUBDIR%/ \
                ftp://ftp.samba.org/pub/%SUBDIR%/ \
@@ -119,7 +120,11 @@
        @${REINPLACE_CMD} -e 's|CFLAGS|CONFIGUREDCFLAGS|' \
                -e 's|perl.*|${DO_NADA}|' \
                        ${WRKSRC}/Makefile.in
+# workaround for bug in configure which ignores --with-rsyncd-conf 
+       @${REINPLACE_CMD} -e 's|RSYNCD_SYSCONF|"${PREFIX}/etc/rsyncd.conf"|' \
+                       ${WRKSRC}/clientserver.c
 
 pre-configure:
        @${REINPLACE_CMD} -e 's:/etc/:${PREFIX}/etc/:g'  \
                ${WRKSRC}/rsync.h ${WRKSRC}/rsync.1 ${WRKSRC}/rsyncd.conf.5

--- patch ends here ---
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-10-03 15:07:15 UTC 
Author: ehaupt
Date: Thu Oct  3 14:07:08 2013
New Revision: 329194
URL: http://svnweb.freebsd.org/changeset/ports/329194

Log:
  Provide a patch to workaround a problem with the configure script ignoring
  --with-rsyncd-conf.
  
  PR:		182596 (based on)
  Submitted by:	Alexey Markov <redrat@mail.ru>

Modified:
  head/net/rsync/Makefile

Modified: head/net/rsync/Makefile
==============================================================================
--- head/net/rsync/Makefile	Thu Oct  3 14:03:29 2013	(r329193)
+++ head/net/rsync/Makefile	Thu Oct  3 14:07:08 2013	(r329194)
@@ -3,6 +3,7 @@
 
 PORTNAME=	rsync
 PORTVERSION=	3.1.0
+PORTREVISION=	1
 CATEGORIES=	net ipv6
 MASTER_SITES=	http://rsync.samba.org/ftp/%SUBDIR%/ \
 		ftp://ftp.samba.org/pub/%SUBDIR%/ \
@@ -119,6 +120,9 @@ post-patch:
 	@${REINPLACE_CMD} -e 's|CFLAGS|CONFIGUREDCFLAGS|' \
 		-e 's|perl.*|${DO_NADA}|' \
 			${WRKSRC}/Makefile.in
+# workaround for bug in configure which ignores --with-rsyncd-conf 
+	@${REINPLACE_CMD} -e 's|RSYNCD_SYSCONF|"${PREFIX}/etc/rsyncd.conf"|' \
+			${WRKSRC}/clientserver.c
 
 pre-configure:
 	@${REINPLACE_CMD} -e 's:/etc/:${PREFIX}/etc/:g'  \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Emanuel Haupt freebsd_committer freebsd_triage 2013-10-03 15:07:26 UTC 
State Changed
From-To: open->closed

Fix committed, thanks for the report.