Bug 182949 - [PATCH] x11-toolkits/fltk: compilation error with Clang
[PATCH] x11-toolkits/fltk: compilation error with Clang
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Pietro Cerutti
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-13 14:40 UTC by dt71
Modified: 2013-10-15 09:30 UTC (History)
0 users

See Also:


Attachments
fltk.patch (667 bytes, patch)
2013-10-13 14:45 UTC, dt71
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dt71 2013-10-13 14:40:00 UTC
Buildlog snippet:

In file included from Fl_Group_Type.cxx:27:
In file included from ./Fl_Widget_Type.h:23:
./Fl_Type.h:39:21: error: friend declaration specifying a default argument must be a definition
  friend Fl_Widget *make_type_browser(int,int,int,int,const char *l=0);

Fix: 

Patch to be uploaded immediately.
Comment 1 Edwin Groothuis freebsd_committer 2013-10-13 14:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gahr

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2013-10-15 09:24:27 UTC
Author: gahr
Date: Tue Oct 15 08:24:14 2013
New Revision: 330371
URL: http://svnweb.freebsd.org/changeset/ports/330371

Log:
  - Fix build in C++11 mode [1]
  - Convert to new LIB_DEPENDS format
  - Convert to OPTIONSng (DOCS)
  - STAGE-clean
  
  PR:		182949 [1]
  Submitted by:	dt71@gmx.com [1]

Added:
  head/x11-toolkits/fltk/files/patch-fluid_Fl_Type.h   (contents, props changed)
Modified:
  head/x11-toolkits/fltk/Makefile
  head/x11-toolkits/fltk/pkg-plist

Modified: head/x11-toolkits/fltk/Makefile
==============================================================================
--- head/x11-toolkits/fltk/Makefile	Tue Oct 15 07:51:18 2013	(r330370)
+++ head/x11-toolkits/fltk/Makefile	Tue Oct 15 08:24:14 2013	(r330371)
@@ -12,8 +12,10 @@ COMMENT=	Cross-platform C++ graphical us
 
 LICENSE=	LGPL20
 
-LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png \
-		jpeg.11:${PORTSDIR}/graphics/jpeg
+OPTIONS_DEFINE=	DOCS
+
+LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png \
+		libjpeg.so:${PORTSDIR}/graphics/jpeg
 
 USE_LDCONFIG=	yes
 USE_XORG=	xft
@@ -31,16 +33,14 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVER
 
 PORTDOCS=	*
 
-MAN1=	fltk-config.1 fluid.1
-MAN3=	fltk.3
+.include <bsd.port.options.mk>
 
-NO_STAGE=	yes
 post-patch:
 	prefix="${PREFIX}" ; plength=$$(($${#prefix}+10)) ; \
 	${REINPLACE_CMD} -e "\|/etc/fltk|{s||${PREFIX}&|;s|10|$${plength}|;}" \
 	${WRKSRC}/src/Fl_Preferences.cxx
 
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 post-install:
 	cd ${WRKSRC}/documentation && ${MAKE} docinstall
 	cd ${WRKSRC}/test && ${MAKE} install

Added: head/x11-toolkits/fltk/files/patch-fluid_Fl_Type.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/x11-toolkits/fltk/files/patch-fluid_Fl_Type.h	Tue Oct 15 08:24:14 2013	(r330371)
@@ -0,0 +1,16 @@
+--- fluid/Fl_Type.h.orig	2013-10-15 09:58:05.000000000 +0200
++++ fluid/Fl_Type.h	2013-10-15 10:01:26.000000000 +0200
+@@ -33,10 +33,12 @@
+ 
+ void set_modflag(int mf);
+ 
++Fl_Widget *make_type_browser(int,int,int,int,const char *l=0);
++
+ class Fl_Type {
+ 
+   friend class Widget_Browser;
+-  friend Fl_Widget *make_type_browser(int,int,int,int,const char *l=0);
++  friend Fl_Widget *make_type_browser(int,int,int,int,const char *l);
+   friend class Fl_Window_Type;
+   virtual void setlabel(const char *); // virtual part of label(char*)
+ 

Modified: head/x11-toolkits/fltk/pkg-plist
==============================================================================
--- head/x11-toolkits/fltk/pkg-plist	Tue Oct 15 07:51:18 2013	(r330370)
+++ head/x11-toolkits/fltk/pkg-plist	Tue Oct 15 08:24:14 2013	(r330371)
@@ -158,4 +158,7 @@ lib/libfltk_images.a
 lib/libfltk_images.so
 lib/libfltk_images.so.1
 lib/libfltk_images.so.1.3
+man/man1/fltk-config.1.gz
+man/man1/fluid.1.gz
+man/man3/fltk.3.gz
 @dirrm include/FL
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pietro Cerutti freebsd_committer 2013-10-15 09:24:35 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!