Bug 184175 - sysutils/py-salt does not install
Summary: sysutils/py-salt does not install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-python (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-22 18:10 UTC by paul
Modified: 2013-12-14 06:05 UTC (History)
0 users

See Also:


Attachments
file.diff (1.05 KB, patch)
2013-11-22 18:10 UTC, paul
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description paul 2013-11-22 18:10:00 UTC
Attempting to install sysutils/salt using the Makefile currently in the port results in this:

% cd /usr/ports/sysutils/salt
% make install
.
.
.
changing mode of /usr/ports/sysutils/salt/work/stage/usr/local/bin/salt to 755
changing mode of /usr/ports/sysutils/salt/work/stage/usr/local/bin/salt-key to 755
running install_data
copying doc/man/salt-master.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt-key.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt-cp.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt-call.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt-syndic.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt-run.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt-minion.1 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man1
copying doc/man/salt.7 -> /usr/ports/sysutils/salt/work/stage/usr/local/man/man7
running install_egg_info
Writing /usr/ports/sysutils/salt/work/stage/usr/local/lib/python2.7/site-packages/salt-0.10.4-py2.7.egg-info
/bin/mkdir -p /usr/local/etc/salt
install  -o root -g wheel -m 444 /usr/ports/sysutils/salt/work/salt-0.10.4/conf/master.template /usr/local/etc/salt/master.sample
install  -o root -g wheel -m 444 /usr/ports/sysutils/salt/work/salt-0.10.4/conf/minion.template /usr/local/etc/salt/minion.sample

==============================================

To configure a Salt Master, do the following:

  o Copy /usr/local/etc/salt/master.sample
    to /usr/local/etc/salt/master
  o Update to meet your needs
  o Set salt_master_enable="YES" in rc.conf

----------------------------------------------

To configure a Salt Minion, do the following:

  o Copy /usr/local/etc/salt/minion.sample
    to /usr/local/etc/salt/minion
  o Update config to point to your Salt Master
  o Set salt_minion_enable="YES" in rc.conf

=============================================

====> Compressing man pages (compress-man)
===> Staging rc.d startup script(s)
===>  Installing for salt-0.10.4
===>  Checking if sysutils/salt already installed
===>   Registering installation for salt-0.10.4 as automatic
pkg-static: lstat(/usr/ports/sysutils/salt/work/stage/usr/local/etc/salt/master.sample): No such file or directory
pkg-static: lstat(/usr/ports/sysutils/salt/work/stage/usr/local/etc/salt/minion.sample): No such file or directory
pkg-static: lstat(/usr/ports/sysutils/salt/work/stage/usr/local/etc/salt/): No such file or directory
pkg-static: unknown keyword stopdaemon, ignoring @stopdaemon
pkg-static: unknown keyword stopdaemon, ignoring @stopdaemon
pkg-static: unknown keyword stopdaemon, ignoring @stopdaemon
*** [fake-pkg] Error code 74

Stop in /usr/ports/sysutils/salt.

Fix: iThe issue here seems to be that salt is installed into a staging directory (sysutils/salt/work/stage) and then installed into $PREFIX from there.  Unfortunately, the post-install target in the current Makefile will install sample configuration files into ${PREFIX}/etc/salt/ (which is /usr/local/etc/salt/ for me).  This breaks the staging area since these files are specified in pkg-plist, but don't exist inwork/stage/.  To fix this, I changed post-install to install the sample configuration and man files into ${STAGEDIR}${PREFIX}.  I don't know if this is the correct fix, but it at least allowed me to install salt.

Also, while I'm here, the man pages are installed, but are not listed in pkg-plist.
How-To-Repeat: 
Attempt to install sysutils/salt
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-24 12:54:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-24 12:54:30 UTC
Maintainer of sysutils/py-salt,

Please note that PR ports/184175 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184175

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-24 12:54:31 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Christer Edwards 2013-11-25 20:07:35 UTC
It looks like you're building a very old version of Salt. In the output I
see "salt 0.10.4", where the current ported version is "salt-0.17.2". Is
there a reason you need such an old build? Have you tried with an updated
ports tree? Please try this build with an updated ports tree and let me
know if the problem persists.
Comment 5 koobs 2013-12-14 05:53:40 UTC
Staging support was added with the port upgrade from 0.16.4 to 0.17.1

http://svnweb.freebsd.org/ports?view=revision&revision=331981

The issue reported and fix is for a pre-STAGE version (0.10.4)

Closing PR -> Invalid
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2013-12-14 06:05:46 UTC
State Changed
From-To: feedback->closed

Invalid with current port version, feedback timeout. Thank you for your 
submission Paul