Bug 184206 - fix audio/x11amp build failure
Summary: fix audio/x11amp build failure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Antoine Brodin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-24 04:20 UTC by TsurutaniNaoki
Modified: 2013-12-02 19:30 UTC (History)
1 user (show)

See Also:

Attachments
x11amp.diff (911 bytes, patch)
2013-12-01 11:02 UTC, TsurutaniNaoki 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TsurutaniNaoki 2013-11-24 04:20:00 UTC 
	I received a mail from pkg-fallout@freebsd.org about errors in
	building audio/x11amp.

Fix: 

Here is a patch.
	I found no problem while using stage, and enebling it.

	BTW, I want to abandon this port.
	I think this port is not used anymore...
Comment 1 TsurutaniNaoki 2013-12-01 11:02:09 UTC 
Oops, I missed the patch.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2013-12-02 19:19:23 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->antoine

Take
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-12-02 19:21:17 UTC 
Author: antoine
Date: Mon Dec  2 19:21:09 2013
New Revision: 335532
URL: http://svnweb.freebsd.org/changeset/ports/335532

Log:
  - Fix build with clang
  - Drop maintainership
  - Stage support
  
  PR:		ports/184206
  Submitted by:	Tsurutani Naoki (maintainer)

Added:
  head/audio/x11amp/files/patch-x11amp__controlsocket.c   (contents, props changed)
  head/audio/x11amp/files/patch-x11amp__playlist.c   (contents, props changed)
Modified:
  head/audio/x11amp/Makefile

Modified: head/audio/x11amp/Makefile
==============================================================================
--- head/audio/x11amp/Makefile	Mon Dec  2 18:53:10 2013	(r335531)
+++ head/audio/x11amp/Makefile	Mon Dec  2 19:21:09 2013	(r335532)
@@ -9,11 +9,12 @@ MASTER_SITES=	LOCAL
 MASTER_SITE_SUBDIR=	hrs
 DISTNAME=	${PORTNAME}-${PORTVERSION:S/.b/-beta/}
 
-MAINTAINER=	turutani@scphys.kyoto-u.ac.jp
+MAINTAINER=	ports@FreeBSD.org
 COMMENT=	X11-based MP3 player with nice graphical interface
 
+LICENSE=	GPLv2
+
 USE_GNOME=	gtk12 esound
-NO_STAGE=	yes
 USE_LDCONFIG=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--disable-static

Added: head/audio/x11amp/files/patch-x11amp__controlsocket.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/x11amp/files/patch-x11amp__controlsocket.c	Mon Dec  2 19:21:09 2013	(r335532)
@@ -0,0 +1,11 @@
+--- ./x11amp/controlsocket.c.orig	1999-04-11 23:26:04.000000000 +0000
++++ ./x11amp/controlsocket.c	2013-12-02 19:13:07.000000000 +0000
+@@ -178,7 +178,7 @@
+ 				if(!select(fd+1,&set,NULL,NULL,&tv))
+ 				{
+ 					close(fd);
+-					return;
++					pthread_exit(NULL);
+ 				}
+ 				pkt = g_malloc0(sizeof(PacketNode));
+ 				read(fd,&pkt->hdr,sizeof(ClientPktHeader));

Added: head/audio/x11amp/files/patch-x11amp__playlist.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/x11amp/files/patch-x11amp__playlist.c	Mon Dec  2 19:21:09 2013	(r335532)
@@ -0,0 +1,11 @@
+--- ./x11amp/playlist.c.orig	1999-04-13 20:26:35.000000000 +0000
++++ ./x11amp/playlist.c	2013-12-02 19:12:21.000000000 +0000
+@@ -224,7 +224,7 @@
+ 		}
+ 		g_list_free(list);
+ 		playlist_generate_shuffle_list();
+-		return;
++		return 0;
+ 	}
+ 	g_free(temp);
+ 	if(dir=opendir(path))
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2013-12-02 19:22:22 UTC 
State Changed
From-To: open->closed

Patch committed, thanks!