Bug 184638 - [ncurses] bump ospeed from short to int
Summary: [ncurses] bump ospeed from short to int
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 9.2-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-09 16:50 UTC by Christian Weisgerber
Modified: 2017-12-31 22:24 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer freebsd_triage 2013-12-09 16:50:00 UTC 
In FreeBSD (all supported versions) the type of the ospeed variable
is defined as "short" in lib/ncurses/ncurses/Makefile.  However,
in contrib/ncurses/ncurses/tinfo/lib_baudrate.c the USE_OLD_TTY
hack is disabled for FreeBSD >=7 since the required 4.3BSD compatibility
goo went away.  As a result, ospeed now needs to be able to hold
values up to 921600 (cf. <sys/_termios.h>), so it must be bumped
from short to int.

Obviously this is a binary-incompatible API change.

Arguably, switching ospeed's type is more intrusive than having
garbage values in ospeed, but we should strive for correctness.

(FWIW, OpenBSD, which is facing the same issue, will switch to int
ospeed.)
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:48 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped