Bug 184709 - graphics/gpicview does not build with clang
Summary: graphics/gpicview does not build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
Depends on:
Reported: 2013-12-11 23:10 UTC by Radim Kolar
Modified: 2013-12-28 23:30 UTC (History)
0 users

See Also:

file.dat (84 bytes, text/plain; charset="iso-8859-2")
2013-12-11 23:21 UTC, Radim Kolar
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Radim Kolar 2013-12-11 23:10:00 UTC
graphics/gpicview does not build with clang on FreeBSD 10. Its due to bug in source code main-win.c:381 non-void function main_win_open should return value
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-12-12 11:08:04 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 2 Edwin Groothuis freebsd_committer 2013-12-12 11:08:21 UTC
Maintainer of graphics/gpicview,

Please note that PR ports/184709 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:

Edwin Groothuis via the GNATS Auto Assign Tool
Comment 3 Edwin Groothuis freebsd_committer 2013-12-12 11:08:22 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer 2013-12-28 23:24:43 UTC
Author: rakuco
Date: Sat Dec 28 23:24:36 2013
New Revision: 337928
URL: http://svnweb.freebsd.org/changeset/ports/337928

  Fix the build with clang.
  PR:		ports/184709
  PR:		ports/184727
  Submitted by:	Radim Kolar <hsn@sendmail.cz>
  Approved by:	maintainer timeout (17 days)

  head/graphics/gpicview/files/patch-main-win.c   (contents, props changed)

Added: head/graphics/gpicview/files/patch-main-win.c
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/gpicview/files/patch-main-win.c	Sat Dec 28 23:24:36 2013	(r337928)
@@ -0,0 +1,11 @@
+--- src/main-win.c.orig	2013-10-23 10:42:02.000000000 +0200
++++ src/main-win.c	2013-12-12 18:26:14.000000000 +0100
+@@ -378,7 +378,7 @@
+         image_list_sort_by_name( mw->img_list, GTK_SORT_DESCENDING );
+         if (image_list_get_first(mw->img_list))
+             main_win_open(mw, image_list_get_current_file_path(mw->img_list), zoom);
+-        return;
++        return TRUE;
+     }
svn-ports-all@freebsd.org mailing list
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Raphael Kubo da Costa freebsd_committer 2013-12-28 23:25:05 UTC
State Changed
From-To: feedback->closed

Fixed by ports/184727.