184901 – www/bookmarkbridge: Fix build with clang

Bug 184901 - www/bookmarkbridge: Fix build with clang

Summary: www/bookmarkbridge: Fix build with clang

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	Normal Affects Only Me
Assignee:	Pawel Pekala

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-12-16 18:10 UTC by tkato432
Modified:	2013-12-24 16:00 UTC (History)
CC List:	0 users

See Also:

Attachments
file.diff (1.66 KB, patch) 2013-12-16 18:10 UTC, tkato432	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description tkato432 2013-12-16 18:10:28 UTC

- Fix build with clang
- Add DESKTOP_ENTRIES
- Support shebangfix

New file:
files/patch-bookmarkbridge__bridgecfg.h

Comment 1 Pawel Pekala freebsd_committer

2013-12-24 13:57:14 UTC

Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.

Comment 2 Pawel Pekala freebsd_committer

2013-12-24 14:23:34 UTC

State Changed
From-To: open->closed

Committed. Thanks!

Comment 3 dfilter service freebsd_committer

2013-12-24 14:23:35 UTC

Author: pawel
Date: Tue Dec 24 14:23:21 2013
New Revision: 337356
URL: http://svnweb.freebsd.org/changeset/ports/337356

Log:
  - Fix build with clang
  - Add desktop entry file
  - Use shebangfix
  - Support staging
  
  PR:		ports/184901
  Submitted by:	KATO Tsuguru <tkato432@yahoo.com>

Added:
  head/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h   (contents, props changed)
Modified:
  head/www/bookmarkbridge/Makefile

Modified: head/www/bookmarkbridge/Makefile
==============================================================================
--- head/www/bookmarkbridge/Makefile	Tue Dec 24 13:54:11 2013	(r337355)
+++ head/www/bookmarkbridge/Makefile	Tue Dec 24 14:23:21 2013	(r337356)
@@ -3,24 +3,22 @@
 
 PORTNAME=	bookmarkbridge
 PORTVERSION=	0.76
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	www
 MASTER_SITES=	SF
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Synchronize bookmarks between multiple browsers
 
-LIB_DEPENDS=	xml2:${PORTSDIR}/textproc/libxml2
-
-USE_PERL5=	build
+USES=		gmake perl5 pkgconfig shebangfix
+SHEBANG_FILES=	bookmarkbridge/docs/autodocs.pl
+USE_PERL5=	yes
 USE_XORG=	x11 ice xext
-USE_QT4=	corelib gui moc_build rcc_build uic_build qt3support
+USE_QT4=	corelib gui qt3support moc_build rcc_build uic_build
 USE_GNOME=	libxml2
-USE_GMAKE=	yes
-USES=		pkgconfig perl5
 USE_AUTOTOOLS=	aclocal automake autoconf
-ACLOCAL_ARGS=	-I ${LOCALBASE}/share/aclocal
 AUTOMAKE_ARGS=	--add-missing
 
-NO_STAGE=	yes
+DESKTOP_ENTRIES="BookmarkBridge" "" "" "${PORTNAME}" "Qt;Network;" ""
+
 .include <bsd.port.mk>

Added: head/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h	Tue Dec 24 14:23:21 2013	(r337356)
@@ -0,0 +1,9 @@
+--- bookmarkbridge/bridgecfg.h.orig	2013-12-06 03:29:29.000000000 +0900
++++ bookmarkbridge/bridgecfg.h	2013-12-06 03:29:46.000000000 +0900
+@@ -31,6 +31,7 @@
+ #include "bknode.h"
+ #include "bkexcept.h"
+ 
++#include <cstdlib>
+ #include <vector>
+ #include <qstring.h>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"

Comment 4 dfilter service freebsd_committer

2013-12-24 15:59:06 UTC

Author: mat
Date: Tue Dec 24 15:58:58 2013
New Revision: 337366
URL: http://svnweb.freebsd.org/changeset/ports/337366

Log:
  MFH: r337356
  
  - Fix build with clang
  - Add desktop entry file
  - Use shebangfix
  - Support staging
  
  PR:		ports/184901
  Submitted by:	KATO Tsuguru <tkato432@yahoo.com>
  Approved by:	portmgr (implicit)

Added:
  branches/2014Q1/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h
     - copied unchanged from r337356, head/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h
Modified:
  branches/2014Q1/www/bookmarkbridge/Makefile
Directory Properties:
  branches/2014Q1/   (props changed)

Modified: branches/2014Q1/www/bookmarkbridge/Makefile
==============================================================================
--- branches/2014Q1/www/bookmarkbridge/Makefile	Tue Dec 24 15:57:54 2013	(r337365)
+++ branches/2014Q1/www/bookmarkbridge/Makefile	Tue Dec 24 15:58:58 2013	(r337366)
@@ -3,24 +3,22 @@
 
 PORTNAME=	bookmarkbridge
 PORTVERSION=	0.76
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	www
 MASTER_SITES=	SF
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Synchronize bookmarks between multiple browsers
 
-LIB_DEPENDS=	xml2:${PORTSDIR}/textproc/libxml2
-
-USE_PERL5=	build
+USES=		gmake perl5 pkgconfig shebangfix
+SHEBANG_FILES=	bookmarkbridge/docs/autodocs.pl
+USE_PERL5=	yes
 USE_XORG=	x11 ice xext
-USE_QT4=	corelib gui moc_build rcc_build uic_build qt3support
+USE_QT4=	corelib gui qt3support moc_build rcc_build uic_build
 USE_GNOME=	libxml2
-USE_GMAKE=	yes
-USES=		pkgconfig perl5
 USE_AUTOTOOLS=	aclocal automake autoconf
-ACLOCAL_ARGS=	-I ${LOCALBASE}/share/aclocal
 AUTOMAKE_ARGS=	--add-missing
 
-NO_STAGE=	yes
+DESKTOP_ENTRIES="BookmarkBridge" "" "" "${PORTNAME}" "Qt;Network;" ""
+
 .include <bsd.port.mk>

Copied: branches/2014Q1/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h (from r337356, head/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2014Q1/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h	Tue Dec 24 15:58:58 2013	(r337366, copy of r337356, head/www/bookmarkbridge/files/patch-bookmarkbridge__bridgecfg.h)
@@ -0,0 +1,9 @@
+--- bookmarkbridge/bridgecfg.h.orig	2013-12-06 03:29:29.000000000 +0900
++++ bookmarkbridge/bridgecfg.h	2013-12-06 03:29:46.000000000 +0900
+@@ -31,6 +31,7 @@
+ #include "bknode.h"
+ #include "bkexcept.h"
+ 
++#include <cstdlib>
+ #include <vector>
+ #include <qstring.h>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"