Bug 185065 - x11/xlockmore: Install failure with GTK2 option - possible STAGING issue
Summary: x11/xlockmore: Install failure with GTK2 option - possible STAGING issue
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-21 13:00 UTC by A.J. "Fonz" van Werven
Modified: 2013-12-29 03:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description A.J. "Fonz" van Werven 2013-12-21 13:00:00 UTC
The port x11/xlockmore builds but fails to install when the option GTK2 has been selected.

A relevant snippet of the portmaster output can be found below. Most of it is still context, though. It's the "pkg-static: lstat(foo): No such file or directory" lines that suggest a STAGING issue.

With the GTK2 option disabled, all is peachy again.

Please note that the /rw/ prefix in the output below comes from my specific jail setup and is unlikely to be a factor (read: shouldn't be).

[portmaster x11/xlockmore output]
xglock BUILD COMPLETE

===>  Staging for xlockmore-5.43
===>   Generating temporary packing list
./mkinstalldirs /rw/usr/ports/x11/xlockmore/work/stage/usr/local/bin
install  -s -o root -g wheel -m 555 -s -o root -m 4111 ../xlock/xlock /rw/usr/ports/x11/xlockmore/work/stage/usr/local/bin
#mkdir -p /usr/local/lib/X11/xlock/modules
#cp *.xlk /usr/local/lib/X11/xlock/modules
#cp glx/*.xlk /usr/local/lib/X11/xlock/modules
./mkinstalldirs /rw/usr/ports/x11/xlockmore/work/stage/usr/local/man/man1
install  -o root -g wheel -m 444 ../xlock/xlock.man /rw/usr/ports/x11/xlockmore/work/stage/usr/local/man/man1/xlock.1
./mkinstalldirs /rw/usr/ports/x11/xlockmore/work/stage/usr/local/lib/X11/app-defaults
install  -o root -g wheel -m 444 ../xlock/XLock.ad /rw/usr/ports/x11/xlockmore/work/stage/usr/local/lib/X11/app-defaults/XLock
install COMPLETE

./mkinstalldirs /rw/usr/ports/x11/xlockmore/work/stage/usr/local/bin
install  -s -o root -g wheel -m 555 xglock /rw/usr/ports/x11/xlockmore/work/stage/usr/local/bin
./mkinstalldirs /usr/local/share/xlock
install  -o root -g wheel -m 444 ../xglock/xglockrc /usr/local/share/xlock/xglockrc
install_xglock COMPLETE

====> Compressing man pages (compress-man)
===>  Installing for xlockmore-5.43
===>  Checking if x11/xlockmore already installed
===>   Registering installation for xlockmore-5.43
pkg-static: lstat(/rw/usr/ports/x11/xlockmore/work/stage/usr/local/share/xlock/xglockrc): No such file or directory
pkg-static: lstat(/rw/usr/ports/x11/xlockmore/work/stage/usr/local/share/xlock/): No such file or directory
*** [fake-pkg] Error code 74

Stop in /rw/usr/ports/x11/xlockmore.
*** [install] Error code 1

How-To-Repeat: # cd /usr/ports/x11/xlockmore
# make config
[select the GTK2 option]
# portmaster x11/xlockmore
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-21 13:00:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2013-12-22 06:09:28 UTC
Please let me know if this patch fixes the issue for you.

Index: Makefile
===================================================================
--- Makefile    (revision 337074)
+++ Makefile    (working copy)
@@ -46,6 +46,7 @@

 MAKE_ARGS+=    bindir=${STAGEDIR}${PREFIX}/bin \
         mandir=${STAGEDIR}${PREFIX}/man/man1 \
+        datarootdir=${STAGEDIR}${PREFIX}/share \
         xapploaddir=${STAGEDIR}${PREFIX}/lib/X11/app-defaults

 .include <bsd.port.options.mk>

Thanks!
-jgh
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2013-12-23 15:53:42 UTC
State Changed
From-To: open->feedback

Please try this patch, and let me know how it fairs for you. 

-jgh
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-12-29 02:56:12 UTC
Author: jgh
Date: Sun Dec 29 02:56:04 2013
New Revision: 337934
URL: http://svnweb.freebsd.org/changeset/ports/337934

Log:
  - unbreak when built with GTK2 option enabled
  - while here fix maintainership for the one slave ports
  
  PR:		185065
  Reported by:	freebsd@skysmurf.nl

Modified:
  head/x11/xlockmore/Makefile

Modified: head/x11/xlockmore/Makefile
==============================================================================
--- head/x11/xlockmore/Makefile	Sun Dec 29 00:37:41 2013	(r337933)
+++ head/x11/xlockmore/Makefile	Sun Dec 29 02:56:04 2013	(r337934)
@@ -8,7 +8,7 @@ MASTER_SITES=	http://www.tux.org/~bagley
 		ftp://ibiblio.org/pub/Linux/X11/screensavers/ \
 		CRITICAL
 
-MAINTAINER=	jgh@FreeBSD.org
+MAINTAINER?=	jgh@FreeBSD.org
 COMMENT=	Like XLock session locker/screen saver, but just more
 
 USE_BZIP2=	yes
@@ -46,6 +46,7 @@ NO_OPTIONS_SORT=yes
 
 MAKE_ARGS+=	bindir=${STAGEDIR}${PREFIX}/bin \
 		mandir=${STAGEDIR}${PREFIX}/man/man1 \
+		datarootdir=${STAGEDIR}${PREFIX}/share \
 		xapploaddir=${STAGEDIR}${PREFIX}/lib/X11/app-defaults
 
 .include <bsd.port.options.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2013-12-29 02:56:31 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!