Bug 185301 - news/inn: INN_LAYOUT ignored on 10.0+
Summary: news/inn: INN_LAYOUT ignored on 10.0+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-30 16:50 UTC by Christian Weisgerber
Modified: 2013-12-31 03:50 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (316 bytes, patch)
2013-12-30 16:50 UTC, Christian Weisgerber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer 2013-12-30 16:50:00 UTC
On FreeBSD 10 and later, the news/inn port ignores the setting of
the INN_LAYOUT variable.

The problem is the use of the :L modifier in Makefile.layout.
FreeBSD 10 uses bmake and the meaning of :L has changed.  bsd.port.mk
works around this with the magic setting .MAKE.FreeBSD_UL=yes, but
Makefile.layout is included before this is in place.

Fix: Maybe including Makefile.layout later (which may be possible due
to make's lazy evaluation), or setting .MAKE.FreeBSD_UL in the port.
How-To-Repeat: 
$ cd /usr/ports/news/inn
$ env INN_LAYOUT=hier make -V INN_DBDIR
/usr/local/news/db
Comment 1 Edwin Groothuis freebsd_committer 2013-12-30 16:50:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->fluffy

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-12-31 03:45:09 UTC
Author: fluffy
Date: Tue Dec 31 03:45:01 2013
New Revision: 338218
URL: http://svnweb.freebsd.org/changeset/ports/338218

Log:
  - Tell bmake we use the old :L :U modifiers
  
  PR:		185301
  Submitted by:	naddy@

Modified:
  head/news/inn/Makefile.layout   (contents, props changed)

Modified: head/news/inn/Makefile.layout
==============================================================================
--- head/news/inn/Makefile.layout	Tue Dec 31 02:54:19 2013	(r338217)
+++ head/news/inn/Makefile.layout	Tue Dec 31 03:45:01 2013	(r338218)
@@ -1,5 +1,8 @@
 # $FreeBSD$
 
+# tell bmake we use the old :L :U modifiers
+.MAKE.FreeBSD_UL= yes
+
 INN_LAYOUT?=		old
 
 .if !empty(INN_LAYOUT:L:Mnew)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dima Panov freebsd_committer 2013-12-31 03:45:47 UTC
State Changed
From-To: open->closed

Committed. Thanks!