Fix: Patch attached with submission follows:
Class Changed From-To: maintainer-update->change-request Fix category (new ports should be change-requests) (via the GNATS Auto Assign Tool)
It would seem that the pkg-descr is inappropriate and needs a proper description of the port. Also, there should be a LICENSE statement in the port, and possibly documentation.
Here is a patch to the original patch that fixes the issues sited: diff -u ./Makefile /home/aegis/i-testing/ baseline/scrap/port/Makefile --- ./Makefile 2014-01-12 08:28:15.000000000 +0000 +++ /home/aegis/i-testing/baseline/scrap/port/Makefile 2014-01-17 05:15:19.000000000 +0000 @@ -1,9 +1,10 @@ CATEGORIES=devel -PORTNAME=src-thistest-aryeh +PORTNAME=src-thistest-aegis PORTVERSION=0.1 -COMMENT=Unit testing framework in Java +COMMENT=Java Unit Testing Framework +LICENSE=BSD -MASTER_SITES= ftp://ftp.fnwe.net/thistest/0.1/aryeh/ +MASTER_SITES= ftp://ftp.fnwe.net/thistest/0.1/aegis/ BUILD_DEPENDS= ${LOCALBASE}/bin/cook:${PORTSDIR}/devel/cook \ ${LOCALBASE}/openjdk7/bin/java:${PORTSDIR}/java/openjdk7 Only in /home/aegis/i-testing/baseline/scrap/port/: distinfo diff -u ./pkg-descr /home/aegis/i-testing/baseline/scrap/port/pkg-descr --- ./pkg-descr 2014-01-12 08:28:15.000000000 +0000 +++ /home/aegis/i-testing/baseline/scrap/port/pkg-descr 2014-01-17 05:15:19.000000000 +0000 @@ -1 +1,3 @@ -lksdf + ThisTest is a Java unit testing framework. You can find documentation at: + + http://localhost:8080/thistest-aryeh-0.1 diff -u ./pkg-plist /home/aegis/i-testing/baseline/scrap/port/pkg-plist --- ./pkg-plist 2014-01-12 08:28:15.000000000 +0000 +++ /home/aegis/i-testing/baseline/scrap/port/pkg-plist 2014-01-17 05:15:22.000000000 +0000 @@ -1,3 +1,3 @@ /usr/local/etc/rc.d/thistest.sh -/usr/local/share/java/classes/thistest-aryeh-0.1.jar -/usr/local/apache-tomcat-7.0/webapps/thistest-aryeh-0.1.war +/usr/local/share/java/classes/thistest-aegis-0.1.jar +/usr/local/apache-tomcat-7.0/webapps/thistest-aegis-0.1.war Only in .: thistest -- Aryeh M. Friedman, Lead Developer, http://www.PetiteCloud.org
I'm also confused, even after the patch-on-patch. The title says this replaces port "devel/thistest". But the patch-on-patch says the new port is "devel/src-thistest-aegis" which seems kind of like nonsense to me. In fact, it seems like the name of the port follows the name of the tarball. Oh, and the original diff is not in unified patch format. Is it STAGE safe? To recap my concerns: 1) The portname looks like it should be "thistest", not "src-thistest-aegis" (use DISTNAME to change name of distfile, not PORTNAME) 2) It may not be jobs safe 3) It's in two different patches, one of which isn't unified format 4) The pkg-descr is still very weak (although to be fair the original port's description was also extremely weak) 5) I'd like to hear that it was tested with poudriere If those were fixed, a brand new diff (or shar as is technically required, but I'm not going to) is submitted, and it has some reasonable testing then I'll pick this up.
It seems that Aryeh has disappeared...