Description Pawel Biernacki 2014-01-08 14:40:00 UTC

rpcgen generates almost correct ANSI C code. The problem is that in generated sample client main function lacks proper declaration by omitting return type. Incorrect declaration also makes it impossible to compile generated code with c++ compiler. Another problem is that sample makefile uses $(RM) macro, but does not define it. Let's change it to just rm as in src/Makefile.inc1.

Fix: Patch attached with submission follows:
How-To-Repeat: $ cat test.x
program TEST_PROG {
    version TEST_VERS {
        int TEST(int) = 1;
    } = 1;
} = 0x23456789;
$ rpcgen -aC test.x
$ make -f makefile.test
cc -O3 -fstrict-aliasing -pipe -march=native -fno-omit-frame-pointer  -c test_clnt.c
cc -O3 -fstrict-aliasing -pipe -march=native -fno-omit-frame-pointer  -c test_client.c
test_client.c:37:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
main(int argc, char *argv[])
^~~~
1 warning generated.
cc -o test_client  test_clnt.o test_client.o
cc -O3 -fstrict-aliasing -pipe -march=native -fno-omit-frame-pointer  -c test_svc.c
cc -O3 -fstrict-aliasing -pipe -march=native -fno-omit-frame-pointer  -c test_server.c
cc -o test_server  test_svc.o test_server.o
$ make -f makefile.test clean
-f core test.h   test_clnt.c test_svc.c test_client.c test_server.c  test_clnt.o test_client.o  test_svc.o test_server.o test_client test_server
make: exec(-f) failed (No such file or directory)
*** Error code 1

Stop.
make: stopped in /usr/home/kaktus/kodzik/rpc/test