Bug 186810 - www/qupzilla should be updated, not marked BROKEN
Summary: www/qupzilla should be updated, not marked BROKEN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-16 05:30 UTC by Matthew Rezny
Modified: 2014-02-16 18:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.16 KB, patch)
2014-02-16 05:30 UTC, Matthew Rezny
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer 2014-02-16 05:30:01 UTC
For reasons I won't even attempt to guess, the Qupzilla port was marked broken instead of being updated. Version 1.6.2 was released the day prior, then 1.6.3 was released the same day that 1.6.1 was marked broken due to fetch failure. The release news expilcitly states 1.6.3 release includes FreeBSD build fixes. Indeed, 4 of the 6 patches are no longer applicable to 1.6.3.

Fix: Remove the obsolete patches

desktop# svnlite status
M       Makefile
M       distinfo
!       files/patch-src__main__main.cpp
!       files/patch-src__plugins__MouseGestures__mousegestures.qrc
!       files/patch-src__plugins__PIM__PIM_res.qrc
!       files/patch-src__plugins__TestPlugin__testplugin.qrc
M       pkg-plist

Update version and distinfo

desktop# svnlite diff
How-To-Repeat: Uhm... please don't repeat this problem, just update the port
Comment 1 Edwin Groothuis freebsd_committer 2014-02-16 05:30:15 UTC
Maintainer of www/qupzilla,

Please note that PR ports/186810 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186810

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2014-02-16 05:30:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Ruslan Makhmatkhanov freebsd_committer 2014-02-16 17:38:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rm

I will take it. Updated port fetchs and build fine. Maintainer, would 
you approve this?
Comment 4 dfilter service freebsd_committer 2014-02-16 18:35:53 UTC
Author: rm
Date: Sun Feb 16 18:35:45 2014
New Revision: 344618
URL: http://svnweb.freebsd.org/changeset/ports/344618
QAT: https://qat.redports.org/buildarchive/r344618/

Log:
  - unbreak by update to latest version: 1.6.3
  - remove patches, applied upstream
  
  PR:		186810
  Submitted by:	Matthew Rezny <matthew@reztek.cz>
  Approved by:	Javad Kouhi <javad.kouhi@gmail.com> (maintainer)

Deleted:
  head/www/qupzilla/files/patch-src__main__main.cpp
  head/www/qupzilla/files/patch-src__plugins__MouseGestures__mousegestures.qrc
  head/www/qupzilla/files/patch-src__plugins__PIM__PIM_res.qrc
  head/www/qupzilla/files/patch-src__plugins__TestPlugin__testplugin.qrc
Modified:
  head/www/qupzilla/Makefile
  head/www/qupzilla/distinfo
  head/www/qupzilla/pkg-descr
  head/www/qupzilla/pkg-plist

Modified: head/www/qupzilla/Makefile
==============================================================================
--- head/www/qupzilla/Makefile	Sun Feb 16 18:32:48 2014	(r344617)
+++ head/www/qupzilla/Makefile	Sun Feb 16 18:35:45 2014	(r344618)
@@ -1,7 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	qupzilla
-PORTVERSION=	1.6.1
+PORTVERSION=	1.6.3
 CATEGORIES=	www
 MASTER_SITES=	http://www.qupzilla.com/uploads/
 DISTNAME=	QupZilla-${PORTVERSION}
@@ -11,8 +11,6 @@ COMMENT=	Modern web browser based on Web
 
 LICENSE=	GPLv3
 
-BROKEN=		Fetch fails
-
 LIB_DEPENDS=	libhunspell-1.3.so:${PORTSDIR}/textproc/hunspell \
 		libexecinfo.so:${PORTSDIR}/devel/libexecinfo
 

Modified: head/www/qupzilla/distinfo
==============================================================================
--- head/www/qupzilla/distinfo	Sun Feb 16 18:32:48 2014	(r344617)
+++ head/www/qupzilla/distinfo	Sun Feb 16 18:35:45 2014	(r344618)
@@ -1,2 +1,2 @@
-SHA256 (QupZilla-1.6.1.tar.gz) = 24fc9a90a9991178a935ab0f5ad2091c52729b08cfd6d8f26f92fef5c0386960
-SIZE (QupZilla-1.6.1.tar.gz) = 4646566
+SHA256 (QupZilla-1.6.3.tar.gz) = ba69b4bb9f9644fcff5945a0b692e6db877e57c2b9d948a7f57ecfcd4a86f7a0
+SIZE (QupZilla-1.6.3.tar.gz) = 5087827

Modified: head/www/qupzilla/pkg-descr
==============================================================================
--- head/www/qupzilla/pkg-descr	Sun Feb 16 18:32:48 2014	(r344617)
+++ head/www/qupzilla/pkg-descr	Sun Feb 16 18:35:45 2014	(r344618)
@@ -16,4 +16,4 @@ developed or very unstable and miss impo
 multiplatform, modern and actively developed browser. QupZilla is trying to
 fill this gap by providing a very stable browsing experience.
 
-WWW: http://www.qupzilla.com
+WWW: http://www.qupzilla.com/

Modified: head/www/qupzilla/pkg-plist
==============================================================================
--- head/www/qupzilla/pkg-plist	Sun Feb 16 18:32:48 2014	(r344617)
+++ head/www/qupzilla/pkg-plist	Sun Feb 16 18:35:45 2014	(r344618)
@@ -2,7 +2,7 @@ bin/qupzilla
 lib/libQupZilla.so
 lib/libQupZilla.so.1
 lib/libQupZilla.so.1.6
-lib/libQupZilla.so.1.6.1
+lib/libQupZilla.so.1.6.3
 lib/qupzilla/libAccessKeysNavigation.so
 lib/qupzilla/libGreaseMonkey.so
 lib/qupzilla/libMouseGestures.so
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Ruslan Makhmatkhanov freebsd_committer 2014-02-16 18:36:23 UTC
State Changed
From-To: feedback->closed

Committed, thank you both!