Bug 186905 - [PATCH] porters-handbook/makefiles/chapter.xml Stripping Binaries and Shared Libraries
Summary: [PATCH] porters-handbook/makefiles/chapter.xml Stripping Binaries and Shared ...
Status: Closed Feedback Timeout
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-doc (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 01:50 UTC by Rusmir Dusko
Modified: 2017-08-04 13:39 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (755 bytes, patch)
2014-02-20 01:50 UTC, Rusmir Dusko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rusmir Dusko freebsd_committer freebsd_triage 2014-02-20 01:50:00 UTC
Porter's Handbook

5.15.2. Stripping Binaries and Shared Libraries

Add example for lighter stripping

Fix: Please commit enclosed porters-handbook_makefiles_chapter.xml.diff

Patch attached with submission follows:
Comment 1 Ed Maste freebsd_committer freebsd_triage 2015-05-19 14:43:25 UTC
The patch is confusing to me:

> --- en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml	(revision 43995)
> +++ en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml	(working copy)
> @@ -4138,6 +4138,14 @@
>  	<buildtarget>post-install</buildtarget> target.  For
>  	example:</para>
>  
> +      <para>First try to use <varname>USES</varname> macros</para>
> +
> +      <programlisting>
> +	  MAKE_ENV= INSTALL_STRIP_FLAG=${STRIP}</programlisting>

* How is this related to the USES macro?
* This is still in the example after "This is typically done within the post-install target," yet this is instead of the post-install target.

> +
> +      <para>When this doesn't work, use in
> +	  <buildtarget>post-install</buildtarget> target.</para>

* In what way would the above not work?

> +
>        <programlisting>post-install:
>  	  ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/xdl</programlisting>