Bug 187286 - [bsd.default-versions.mk] [patch] Default PostgreSQL version needs to be updated to 9.3
Summary: [bsd.default-versions.mk] [patch] Default PostgreSQL version needs to be upda...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-05 16:50 UTC by ftigeot
Modified: 2014-12-08 10:01 UTC (History)
7 users (show)

See Also:


Attachments
patch-bsd.default-versions.mk (324 bytes, text/x-makefile)
2014-03-06 10:33 UTC, ftigeot
no flags Details
pg92.diff (1.12 KB, patch)
2014-05-18 21:13 UTC, Mark Felder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ftigeot 2014-03-05 16:50:00 UTC
The default Postgres version in ports is 9.0

The Postgres 9.x branch is very old and three major versions have been released since then.
It would be more useful these days for the default version to be switched to the 9.3 branch.

This would allow binary packages to be used and Postgres to run out of the box on new FreeBSD installations without having to tune SystemV shared memory parameters.

Fix: 

Change the default PostgreSQL version to 9.3 somewhere deep in /usr/ports/Mk
How-To-Repeat: Try to install anything depending on a Postgres port, such as p5-DBD-Pg; it will pull a Postgres 9.0.x port or package.
Comment 1 ftigeot 2014-03-06 10:33:28 UTC
FreeBSD-gnats-submit@FreeBSD.org wrote:
> Thank you very much for your problem report.
> It has the internal identification `ports/187286'.

Add patch for completeness.

-- 
Francois Tigeot
Comment 2 Palle Girgensohn 2014-03-10 11:17:22 UTC
See ports/180010 as well. I agree we should definitely bump default postgresql to 9.3, and now would be a good time. I don't have the time to test it at present though.
Comment 3 freebsd.contact 2014-03-31 16:27:06 UTC
Palle,
FWIW, Dragonfly has been running with PostgreSQL 9.2 as default for over
a year.  We've already fixed ports to either run with PGSQL 9.2 or note
their maximum PGSQL support.

You don't need any exp-run for PGSQL 9.2, you can just turn it on
confidently and I don't see any reason to wait for that version.

For PGSQL 9.3, we can't make the same claim.  We don't know any more
than you do.  It would need an need a new exp-run probably.

John
Comment 4 Mark Felder freebsd_committer freebsd_triage 2014-05-18 21:13:28 UTC
9.2 would also be the safer bet now that performance problems with mmap have surfaced. We should probably stay with 9.2 until we have a way to default to sysv on FreeBSD releases that do not have their mmap performance fixed. To my knowledge there has not been a proposed patch for any release or head/CURRENT yet.
Comment 5 ftigeot 2014-05-18 22:25:06 UTC
On Sun, May 18, 2014 at 03:13:28PM -0500, Mark Felder wrote:
> 9.2 would also be the safer bet now that performance problems with mmap have surfaced. We should probably stay with 9.2 until we have a way to default to sysv on FreeBSD releases that do not have their mmap performance fixed. To my knowledge there has not been a proposed patch for any release or head/CURRENT yet.
> 

AFAIK, the performance problem is a general FreeBSD kernel issue, not
really something mmap specific.

There may be some performance differences between Postgres 9.3 and
Postgres 9.2 on FreeBSD but it's nothing compared to the gap between
FreeBSD and Linux.

-- 
Francois Tigeot
Comment 6 Mark Felder freebsd_committer freebsd_triage 2014-05-19 02:18:05 UTC
On May 18, 2014, at 16:25, Francois Tigeot <ftigeot@wolfpond.org> wrote:

> There may be some performance differences between Postgres 9.3 and
> Postgres 9.2 on FreeBSD but it's nothing compared to the gap between
> FreeBSD and Linux.

This is true, but we may not want to widen the performance gap experience=
d by the general userbase.

"With 9.2, up to 17 % more TPS could be achived (for 32 clients)." =
-girgen@
Comment 7 Dan Langille 2014-05-19 19:37:33 UTC
What needs to be done and how can I help?

Now that BSDCan is over, PGCon is about the start.  I have *all* the PostgreSQL developers here in Ottawa.

-- 
Dan Langille - http://langille.org
Comment 8 ftigeot 2014-05-23 13:51:33 UTC
On Sun, May 18, 2014 at 08:18:05PM -0500, Mark Felder wrote:
> 
> On May 18, 2014, at 16:25, Francois Tigeot <ftigeot@wolfpond.org> wrote:
> 
> > There may be some performance differences between Postgres 9.3 and
> > Postgres 9.2 on FreeBSD but it's nothing compared to the gap between
> > FreeBSD and Linux.
> 
> This is true, but we may not want to widen the performance gap experienced by the general userbase.
> 
> "With 9.2, up to 17 % more TPS could be achived (for 32 clients)." -girgen@

This may be true but has nothing to do with the matter at hand.

Postgres 9.0 and 9.1 are years old, they are useless.
9.4 is currently in beta and the 9.5 development cycle has already started.

I'm currently at PGCon and one of the frequent complaints I have been hearing
about is operating system vendors continuing to ship obsolete versions.

By refusing to update the default version of PostgreSQL used in ports to
something relatively recent, you're effectively rendering FreeBSD less
attractive as a platform.

-- 
Francois Tigeot
Comment 9 Mark Felder freebsd_committer freebsd_triage 2014-05-27 20:57:42 UTC
On 2014-05-23 07:51, Francois Tigeot wrote:
> On Sun, May 18, 2014 at 08:18:05PM -0500, Mark Felder wrote:
>>=20
>> On May 18, 2014, at 16:25, Francois Tigeot <ftigeot@wolfpond.org>=20
>> wrote:
>>=20
>> > There may be some performance differences between Postgres 9.3 and
>> > Postgres 9.2 on FreeBSD but it's nothing compared to the gap between
>> > FreeBSD and Linux.
>>=20
>> This is true, but we may not want to widen the performance gap=20
>> experienced by the general userbase.
>>=20
>> "With 9.2, up to 17 % more TPS could be achived (for 32 clients)."=20
>> -girgen@
>=20
> This may be true but has nothing to do with the matter at hand.
>=20
> Postgres 9.0 and 9.1 are years old, they are useless.
> 9.4 is currently in beta and the 9.5 development cycle has already=20
> started.
>=20
> I'm currently at PGCon and one of the frequent complaints I have been=20
> hearing
> about is operating system vendors continuing to ship obsolete versions.
>=20
> By refusing to update the default version of PostgreSQL used in ports=20
> to
> something relatively recent, you're effectively rendering FreeBSD less
> attractive as a platform.

CC'ing mat@

Francois has an excellent point. Maybe we should just do the exp-run on=20
9.3 and be done with it? Let the pg guys and our guys figure out the=20
performance impact (which might be false as tests were not done with=20
*remote* clients) and at least keep our platform attractive to postgres=20
users.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-07 15:47:42 UTC
Adding back all the folks that got lost in the bugzilla conversion: mat, feld, girgen, me, dvl


Is anything going to happen here?  Who should be assigned the PR?
Comment 11 Mathieu Arnold freebsd_committer freebsd_triage 2014-08-07 16:01:43 UTC
The one who should be assigned the PR should be the one who is going to follow up after the exp-run and fix the fallout. (not me, atm)
Comment 12 John Marino freebsd_committer freebsd_triage 2014-08-07 16:10:38 UTC
Mat, I don't believe the PR has ever been assigned.  At least not from the comments here and the bugzilla history is completely blank.
Comment 13 John Marino freebsd_committer freebsd_triage 2014-08-07 16:11:30 UTC
Oh, I misunderstood.  You're saying "don't assign the PR to me" that's all.
Comment 14 John Marino freebsd_committer freebsd_triage 2014-12-07 11:01:31 UTC
Okay, I think this can be switched now.  The exp-run has been performed.  As a result:

  * one port removed (databases/postgresql93-plv8js, duplicate port)
  * two ports deprecated for removal (devel/prepstools + gui, no upstream)
  * four ports marked as pgsql 9.2 and lower only

Of the latter four, three of them can be updated to a newer version that will support pgsql 9.3.  All four have the same maintainer who has not responded thus far.  However, now that his ports are properly marked, we don't need to wait on this. 

So I don't see any obstacles left to bumping the default version of pgsql to 9.3
Comment 15 Palle Girgensohn freebsd_committer freebsd_triage 2014-12-07 11:09:25 UTC
Lovely! Well done.
Comment 16 commit-hook freebsd_committer freebsd_triage 2014-12-08 09:57:28 UTC
A commit references this bug:

Author: marino
Date: Mon Dec  8 09:57:24 UTC 2014
New revision: 374256
URL: https://svnweb.freebsd.org/changeset/ports/374256

Log:
  Change PostgreSQL default version from 9.2 to 9.3

  An exp-run has been performed on this default version change, and both
  pgsql and portmgr are aware of this change.  Note that PR originally
  made the jump from 9.0 to 9.3, but a conservative change to 9.2 was
  done in May instead.

  PR:	187286

Changes:
  head/Mk/bsd.default-versions.mk
  head/UPDATING
Comment 17 John Marino freebsd_committer freebsd_triage 2014-12-08 10:01:40 UTC
Okay, it was a long road, but now the default version of postgres is 9.3, so I'm closing the PR.