Bug 187513 - [MAINTAINER] security/libscrypt: Update to 1.18
Summary: [MAINTAINER] security/libscrypt: Update to 1.18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 22:10 UTC by Horia Racoviceanu
Modified: 2014-03-13 16:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.87 KB, patch)
2014-03-12 22:10 UTC, Horia Racoviceanu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Horia Racoviceanu 2014-03-12 22:10:00 UTC

Fix: - Version update to 1.18, Announce message:
  Replaced the b64 libraries with more portable one from ISC. Now tested and
  verified on a wider variety of architectures. Note, libscrypt_b64_encrypt was
  originally an exported function. This is no longer the case as it is
  considered an internal function only.

- Remove STATIC lib
- Change REINPLACE for CC, CFLAGS, LDFLAGS and LIBDIR
- Remove CFLAGS, now in REINPLACE
- Strip library

Build log:
https://redports.org/buildarchive/20140312211634-16716/

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2014-03-12 22:10:09 UTC
Class Changed
From-To: change-request->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2014-03-12 22:10:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer 2014-03-13 16:07:45 UTC
Author: swills
Date: Thu Mar 13 16:07:38 2014
New Revision: 348094
URL: http://svnweb.freebsd.org/changeset/ports/348094
QAT: https://qat.redports.org/buildarchive/r348094/

Log:
  - Version update to 1.18
  - Remove STATIC lib
  - Change REINPLACE for CC, CFLAGS, LDFLAGS and LIBDIR
  - Remove CFLAGS, now in REINPLACE
  - Strip library
  
  PR:		ports/187513
  Submitted by:	Horia Racoviceanu <horia@racoviceanu.com> (maintainer)

Modified:
  head/security/libscrypt/Makefile
  head/security/libscrypt/distinfo

Modified: head/security/libscrypt/Makefile
==============================================================================
--- head/security/libscrypt/Makefile	Thu Mar 13 16:01:10 2014	(r348093)
+++ head/security/libscrypt/Makefile	Thu Mar 13 16:07:38 2014	(r348094)
@@ -2,8 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	libscrypt
-PORTVERSION=	1.14
-PORTREVISION=	1
+PORTVERSION=	1.18
 CATEGORIES=	security
 
 MAINTAINER=	horia@racoviceanu.com
@@ -16,22 +15,24 @@ USE_LDCONFIG=	yes
 USE_GITHUB=	yes
 GH_ACCOUNT=	technion
 GH_TAGNAME=	${GH_COMMIT}
-GH_COMMIT=	8e6966e
+GH_COMMIT=	35b6894
 
 PLIST_FILES=	include/libscrypt.h \
-		lib/libscrypt.a \
 		lib/libscrypt.so \
 		lib/libscrypt.so.0
 
 PORTDOCS=	README.md
-
 OPTIONS_DEFINE=	DOCS
 
+.include <bsd.port.pre.mk>
+
 post-patch:
-	@${REINPLACE_CMD} -e '/^CC=gcc/d' -e '/CFLAGS=/s|$$| ${CFLAGS}|' \
-		-e 's|/usr/local|${PREFIX}| ; \
-		s|install: library|& install-static| ; \
-		s|$$(LDFLAGS)||' ${WRKSRC}/Makefile
+	@${REINPLACE_CMD} -e 's|CC?=gcc|CC?=${CC}|; s|CFLAGS?=|CFLAGS+=|; \
+		s|LIBDIR       ?|LIBDIR        |' ${WRKSRC}/Makefile
+
+.if ${ARCH} == i386 && ${COMPILER_TYPE} == gcc
+	@${REINPLACE_CMD} -e 's|stack-protector|no-&|' ${WRKSRC}/Makefile
+.endif
 
 regression-test: build
 	(cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} check)
@@ -40,10 +41,6 @@ post-install:
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
-.include <bsd.port.pre.mk>
-
-.if ${ARCH} == i386 && ${COMPILER_TYPE} == gcc
-CFLAGS+=	-fno-stack-protector
-.endif
+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}.so.0
 
 .include <bsd.port.post.mk>

Modified: head/security/libscrypt/distinfo
==============================================================================
--- head/security/libscrypt/distinfo	Thu Mar 13 16:01:10 2014	(r348093)
+++ head/security/libscrypt/distinfo	Thu Mar 13 16:07:38 2014	(r348094)
@@ -1,2 +1,2 @@
-SHA256 (libscrypt-1.14.tar.gz) = 08d9f83eee4f2eb00c740357fd3648ce7d038ba4b5af2ee9fdc4319f76113e8b
-SIZE (libscrypt-1.14.tar.gz) = 20562
+SHA256 (libscrypt-1.18.tar.gz) = 5c8c59cc76bbbcb9d674fb72a668938cd2d6c5e1d5a302a8dc83f541f33b65ea
+SIZE (libscrypt-1.18.tar.gz) = 17418
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Steve Wills freebsd_committer 2014-03-13 16:07:52 UTC
State Changed
From-To: open->closed

Committed. Thanks!