Bug 187623 - [NEW PORT] net-mgmt/nagios-check_dhcp.pl: Check the availabiliyt of DHCP server using unicast
Summary: [NEW PORT] net-mgmt/nagios-check_dhcp.pl: Check the availabiliyt of DHCP serv...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-15 22:10 UTC by Lawrence Chen
Modified: 2014-10-05 21:41 UTC (History)
1 user (show)

See Also:

Attachments
nagios-check_dhcp.pl.shar (2.25 KB, text/plain)
2014-03-15 22:10 UTC, Lawrence Chen 		no flags Details
poudriere testport log (11.58 KB, text/x-log)
2014-08-28 13:51 UTC, Lawrence Chen 		no flags Details
updated nagios-check_dhcp.pl.shar (2.22 KB, text/plain)
2014-08-28 14:43 UTC, Lawrence Chen 		no flags Details
testport results after update (11.51 KB, text/plain)
2014-08-28 14:44 UTC, Lawrence Chen 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2014-03-15 22:10:01 UTC 
	
	This plugin tests the availability of a given DHCP server using unicast
	delivery.  This is necessary if the monitoring host is on a different
	subnet.  Using broadcast and a DHCP relay would also prevent the check
	from probing individual servers.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-07 14:46:37 UTC 
Hi, if you are still interested in having this port in FreeBSD, it may (or may not) need to be reworked to support stage, and it may need updating to other newer conventions such as "USES" which is expanding all time.
For staging, see http://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-May/000080.html


Additionally, you need to provide some sort of quality assurance.    
In order of preference, we are looking for:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs

Please provide an updated shar file and attach a test log.  Alternatively, please indicate if you are no longer interested in having this software in the Ports Collection and that we can close the PR.

Thanks!
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-24 19:18:44 UTC 
port seems staged, no bitrot, also very simple.  Somebody could take this without a testlog with little risk, although it would have been nice to get one.
Comment 3 Lawrence Chen 2014-08-28 13:51:13 UTC 
Created attachment 146449 [details]
poudriere testport log

Only just got past the last obstacle (ignoring that I'm in the middle of replacing failing root disk) to getting poudriere working...
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-28 13:54:21 UTC 
what about this warning?

Warning: Possibly owned by dependency: @dirrmtry libexec/nagios


That implies the line could be removed from pkg-plist if libexec/nagios exists prior to building in 100% of the cases.
Comment 5 Lawrence Chen 2014-08-28 14:43:33 UTC 
Created attachment 146452 [details]
updated nagios-check_dhcp.pl.shar
Comment 6 Lawrence Chen 2014-08-28 14:44:36 UTC 
Created attachment 146453 [details]
testport results after update
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-28 14:47:40 UTC 
I've no problems setting this to "patch-ready" !
Comment 8 Bartek Rutkowski freebsd_committer freebsd_triage 2014-09-25 18:05:37 UTC 
Hi,

I've tested the patch, and it fails for me: http://pd.valinor.palantiri.org/build.html?mastername=11amd64-default&build=2014-09-25_20h03m38s

Could you take a look and see if you can send a patch with a fix?
Comment 9 Bartek Rutkowski freebsd_committer freebsd_triage 2014-09-30 11:50:50 UTC 
Any news on that?
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-10-05 21:40:37 UTC 
A commit references this bug:

Author: robak
Date: Sun Oct  5 21:40:31 UTC 2014
New revision: 370131
URL: https://svnweb.freebsd.org/changeset/ports/370131

Log:
  net-mgmt/nagios-check_dhcp.pl: NEW PORT - Nagios DHCP check plugin

  This plugin tests the availability of a given DHCP server using unicast
  delivery.

  PR:		187623
  Submitted by:	Lawrence Chen <beastie@tardisi.com>
  Approved by:	mentors (implicit)

Changes:
  head/net-mgmt/Makefile
  head/net-mgmt/nagios-check_dhcp.pl/
  head/net-mgmt/nagios-check_dhcp.pl/Makefile
  head/net-mgmt/nagios-check_dhcp.pl/distinfo
  head/net-mgmt/nagios-check_dhcp.pl/pkg-descr
Comment 11 Bartek Rutkowski freebsd_committer freebsd_triage 2014-10-05 21:41:57 UTC 
Committed with minor changes, thanks for your work!