Magit is an interface to the version control system Git, implemented as an Emacs extension. Unlike Emacs' native Version Control package which strives to provide a unified interface to various version control systems, Magit only supports Git and can therefore better take advantage of its native features. WWW: http://magit.github.io/magit/ Generated with FreeBSD Port Tools 1.00.2014.03.16 (mode: new) This port depends on newly submmitted devel/git-modes port. So please commit ports/187781 and this port together.
I forgot to add DOCS option. So plese commit attached shar file instaed of original one. Regards. --- Yasuhiro KIMURA
Created attachment 143604 [details] Update to latest snapshot * Update to latest snapshot * Add GIT_SUBVERSION option So please commit attached shar file instead of previous ones.
Hi, if you are still interested in having this port in FreeBSD, it may (or may not) need to be reworked to support stage, and it may need updating to other newer conventions such as "USES" which is expanding all time. For staging, see http://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-May/000080.html Additionally, you need to provide some sort of quality assurance. In order of preference, we are looking for: 1) "poudriere testport" or "poudriere bulk -t" logs 2) Redports or tinderbox logs 3) at least this: https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html Please provide an updated shar file and attach a test log. Alternatively, please indicate if you are no longer interested in having this software in the Ports Collection and that we can close the PR. Thanks!
Created attachment 145749 [details] Update to latest snapshot
Thanks! I still need build quality verification though. Is that forthcoming?
Created attachment 145760 [details] fix build on 11-CURRENT
(In reply to John Marino from comment #5) > Thanks! I still need build quality verification though. Is that > forthcoming? Following is build result on redports. https://redports.org/buildarchive/20140813093400-55624/ Best Regards.
did you accidentally make the shar attachment obsolete, or do you intend to upload a new one?
oh nevermind, the new attachment is a shar, I thought it was a log. :)
Okay, it's been a long road (5 months), but pushing for those logs seems to result in a good submission so it's ready for a committer to take a serious look. Moving to patch-ready.
Sorry, I just notice that devel/magit exists. What is the purpose of magit-devel? In other words, why does it need to exist along side of devel/magit? Is it not better to just update devel/magit with this port? I'll make you the maintainer for devel/magit if we do that.
FWIW I confirmed this builds cleanly and is ready for commit. We just need to understand "why -devel?" Some of us really don't like "-devel" ports and are actively seeking to reduce them in ports, this is why I'm asking for justification.
For Yasuhiro KIMURA: the PR is on hold awaiting your response
I am going to close this PR soon without committing anything due to lack of feedback from Yasuhiro KIMURA.
To be clear, I didn't reject the PR. I only wanted justification for a new port instead of updating the original port.