- update to 4.4.1; see release notes: http://sourceforge.net/projects/davmail/files/davmail/4.4.1/releasenotes.txt/view - various general port modernizations: - stagify - USE_DOS2UNIX -> USES=dos2unix - fix procname in rc.d/davmail so 'service davmail stop' works - log to syslog in rc.d/davmail instead of /var/log/davmail-error.log (the latter grows forever unless one manually adds an entry to newsyslog, and even then, rotation of the shell redirection file becomes a problem) - in both rc.d/davmail and bin/davmail, use "$BASE/lib/*" for CLASSPATH instead of iterating over all the jar files separately adding all of them to CLASSPATH and passing that on the command line (makes for a long command line). [see http://download.java.net/jdk7u6/docs/technotes/tools/solaris/classpath.html] - in bin/davmail, exec java to avoid an extra shell process lying around There is another potential patch that removes the need for swt. But it's not obvious to me if this is correct. It seems to run fine without swt installed. I noticed that swt-devel.jar is installed and rc.d/davmail and bin/davmail reference swt.jar. I was surprised that everything I tested (gui version and non-gui version) worked fine without any swt installed. A patch to remove that will come in a separate submission, but I wanted to kickstart discussion about this matter - if it really is not needed (and if so, what changed to make that so). I haven't asked on the davmail email list yet.
Here's a patch version that removes swt. I've tried running with and without swt installed (and swt-devel installed and pointed CLASSPATH at swt-devel.jar) and don't see any obvious difference. Maybe I'm missing something. And it's pretty clear that since swt-devel installs swt-devel.jar and the davmail scripts point to swt.jar that it hasn't been a problem (unless someone had a stale swt.jar lying around, but I looked and don't have one).
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Maintainer of mail/davmail, Please note that PR ports/187796 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187796 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
It has been confirmed on the davmail list that swt is not needed. Use the second patch.
Thank you, John Hein, for the dilligent research and patchwork you put in to this update. I happily approve of this 4.2.1 => 4.4.1 update (patch-4.4.1-noswt).
Comment on attachment 141079 [details] file.diff First patch ("file.diff" attachment 141079 [details]) is obsolete (we need an 'mark this patch obsolete' option for freebsd bugzilla): https://bugs.freebsd.org/bugzilla/attachment.cgi?id=141079&action=edit
Thanks, John.
Created attachment 143457 [details] refresh patch after some parts applied to svn independently This is just a respin of the approved patch updated against the latest svn (bapt converted to USES=dos2unix separately in r355288).
Comment on attachment 141079 [details] file.diff obsolete according to submitter
A commit references this bug: Author: mandree Date: Fri Jun 6 18:01:11 UTC 2014 New revision: 356827 URL: http://svnweb.freebsd.org/changeset/ports/356827 Log: - update to 4.4.1; see release notes: http://sourceforge.net/projects/davmail/files/davmail/4.4.1/releasenotes.txt/view - various general port modernizations: - stagify - USE_DOS2UNIX -> USES=dos2unix - fix procname in rc.d/davmail so 'service davmail stop' works - log to syslog in rc.d/davmail instead of /var/log/davmail-error.log (the latter grows forever unless one manually adds an entry to newsyslog, and even then, rotation of the shell redirection file becomes a problem) - in both rc.d/davmail and bin/davmail, use "$BASE/lib/*" for CLASSPATH instead of iterating over all the jar files separately adding all of them to CLASSPATH and passing that on the command line (makes for a long command line). [see http://download.java.net/jdk7u6/docs/technotes/tools/solaris/classpath.html] - in bin/davmail, exec java to avoid an extra shell process lying around - remove swt PR: 187796 Submitted by: John Hein Approved by: john.c.prather@gmail.com (maintainer) Changes: head/mail/davmail/Makefile head/mail/davmail/distinfo head/mail/davmail/files/davmail.in head/mail/davmail/files/davmail.sh.in head/mail/davmail/pkg-plist
Comment on attachment 141080 [details] patch-4.4.1-noswt superseded by newer patch
John Hein, thanks for your submission. please check if the commit r356827 to the ports tree resolves all your issues and if it does, set this bug's status to Loop Closed. John C. Prather, thank you for reviewing and approving of the patches.
Thanks for committing, Matthias. Status can be changed to FIXED / VERIFIED. But I can't make the change. I don't have permissions to make that kind of change to bugs at this time.
No longer needed, we'll leave it at Issue Resolved/FIXED.