Bug 188446 - mail/mail-notification fails to install
Summary: mail/mail-notification fails to install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-11 04:00 UTC by Jonathan Chen
Modified: 2014-06-29 12:53 UTC (History)
2 users (show)

See Also:


Attachments
file.diff (743 bytes, patch)
2014-04-11 04:00 UTC, Jonathan Chen
no flags Details | Diff
Unbreak staging (1.43 KB, patch)
2014-06-29 10:06 UTC, mwisnicki+freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2014-04-11 04:00:00 UTC
# cd /usr/ports/mail/mail-notification && make install
[...]
===>   Generating temporary packing list
cd /usr/ports/mail/mail-notification/work/mail-notification-5.4 && ./jb install
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/icons/hicolor/16x16/apps/mail-notification.png
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/icons/hicolor/22x22/apps/mail-notification.png
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/icons/hicolor/24x24/apps/mail-notification.png
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/icons/hicolor/32x32/apps/mail-notification.png
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/icons/hicolor/48x48/apps/mail-notification.png
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/icons/hicolor/scalable/apps/mail-notification.svg
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/mail-notification/logo.png
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/mail-notification/gmail.png
updating the GTK+ icon cache
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/applications/mail-notification-properties.desktop
installing /usr/ports/mail/mail-notification/work/stage/usr/local/etc/xdg/autostart/mail-notification.desktop
installing /usr/ports/mail/mail-notification/work/stage/usr/local/etc/gconf/schemas/mail-notification.schemas
installing GConf schemas mail-notification.schemas
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/mail-notification/new-mail.wav
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/gnome/help/mail-notification/C/mail-notification.xml
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/gnome/help/mail-notification/C/documentation-license.xml
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/gnome/help/mail-notification/C/software-license.xml
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/gnome/help/mail-notification/C/figures/mail.png
installing /usr/local/share/omf/mail-notification/mail-notification-C.omf
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/bg/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/ca/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/cs/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/de/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/es/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/fr/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/ja/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/nl/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/pl/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/pt/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/pt_BR/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/ru/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/sr/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/sr@Latn/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/locale/sv/LC_MESSAGES/mail-notification.mo
installing /usr/ports/mail/mail-notification/work/stage/usr/local/bin/mail-notification
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/mail-notification/mailbox-properties-dialog.glade
installing /usr/ports/mail/mail-notification/work/stage/usr/local/share/mail-notification/properties-dialog.glade

Mail Notification 5.4 was installed successfully.
====> Compressing man pages (compress-man)
===>  Installing for mail-notification-5.4_11
===>  Checking if mail/mail-notification already installed
===>   Registering installation for mail-notification-5.4_11
pkg-static: lstat(/usr/ports/mail/mail-notification/work/stage/usr/local/share/omf/mail-notification/mail-notification-C.omf):
No such file or directory
pkg-static: lstat(/usr/ports/mail/mail-notification/work/stage/usr/local/share/omf/mail-notification/):
No such file or directory

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-11 04:00:04 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-11 04:00:04 UTC
Maintainer of mail/mail-notification,

Please note that PR ports/188446 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188446

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Jonathan Chen 2014-04-11 04:46:21 UTC
Unfortunately, I've discovered that the patch is incomplete, as icons
are not installing under /usr/local, and there are references to the
staging directory within the omf file. Staging support is just not
quite there for this port.
-- 
Jonathan Chen <jonc@chen.org.nz>
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-04-20 21:10:45 UTC
Author: antoine
Date: Sun Apr 20 20:10:43 2014
New Revision: 351639
URL: http://svnweb.freebsd.org/changeset/ports/351639
QAT: https://qat.redports.org/buildarchive/r351639/

Log:
  Mark broken, Violates stagedir and fails to package
  
  PR:		ports/188446
  Reported by:	pkg-fallout

Modified:
  head/mail/mail-notification/Makefile

Modified: head/mail/mail-notification/Makefile
==============================================================================
--- head/mail/mail-notification/Makefile	Sun Apr 20 20:02:06 2014	(r351638)
+++ head/mail/mail-notification/Makefile	Sun Apr 20 20:10:43 2014	(r351639)
@@ -11,6 +11,8 @@ MASTER_SITE_SUBDIR=	mailnotify
 MAINTAINER=	mwisnicki+freebsd@gmail.com
 COMMENT=	A mail notification for freedesktop.org-compliant system trays
 
+BROKEN=		Violates stagedir and fails to package
+
 LIB_DEPENDS=	libdbus-glib-1.so:${PORTSDIR}/devel/dbus-glib \
 		libgnome-keyring.so:${PORTSDIR}/security/gnome-keyring \
 		libnotify.so:${PORTSDIR}/devel/libnotify
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Jonathan Chen 2014-04-23 04:56:13 UTC
Hi,

Would it be terribly bad if the port were to revert back to
NO_STAGE=yes? I've tried to figure out how the "jb" program works, but
got lost digging for a way to implement staging support.

A local version with staging support removed installs and works as expected.

Cheers.
-- 
Jonathan Chen <jonc@chen.org.nz>
Comment 6 John Marino freebsd_committer freebsd_triage 2014-06-10 13:11:12 UTC
it is not an option to forgo staging support.  All non-staged ports will eventually be removed anyway.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-06-10 13:13:09 UTC
I don't know where the maintainer is, I just re-added him back to the PR.

Marcin, are you still maintaining this BROKEN port?
Comment 8 mwisnicki+freebsd 2014-06-10 13:23:37 UTC
Sort-of. I'm interested in having it working since I still use it and don't know of a better replacement but I didn't have any free time lately. I hope to fix it before June 30 deadline (I'll have some time next week) if no one else does it before me.
Comment 9 mwisnicki+freebsd 2014-06-29 10:06:05 UTC
Created attachment 144239 [details]
Unbreak staging

This should solve the problem.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-06-29 10:27:34 UTC
shouldn't "cd ${WRKSRC} && ${MAKE_ENV} ./jb build" actually be
"cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ./jb build"  ??
Comment 11 mwisnicki+freebsd 2014-06-29 10:32:45 UTC
Yes, it probably should. And everywhere else too.
Comment 12 John Marino freebsd_committer freebsd_triage 2014-06-29 10:36:54 UTC
may I ask what kind of verification was done on this patch?
Comment 13 mwisnicki+freebsd 2014-06-29 10:38:49 UTC
(In reply to John Marino from comment #12)
> may I ask what kind of verification was done on this patch?

poudriere testport mail-notification

I hope that's enough ?
Comment 14 John Marino freebsd_committer freebsd_triage 2014-06-29 10:45:40 UTC
yes, that's good.
Comment 15 commit-hook freebsd_committer freebsd_triage 2014-06-29 12:50:58 UTC
A commit references this bug:

Author: marino
Date: Sun Jun 29 12:50:43 UTC 2014
New revision: 359762
URL: http://svnweb.freebsd.org/changeset/ports/359762

Log:
  mail/notify: Unbreak

  PR:		188446
  Reported by:	Jonathan Chen
  Submitted by:	maintainer (mwisnicki)
  Tweaks:		marino

Changes:
  head/mail/mail-notification/Makefile
Comment 16 John Marino freebsd_committer freebsd_triage 2014-06-29 12:53:00 UTC
Thanks!