Bug 188640 - [patch] x11-servers/xorg-server is make jobs safe
Summary: [patch] x11-servers/xorg-server is make jobs safe
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 05:30 UTC by Jia-Shiun Li
Modified: 2014-12-23 23:50 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (491 bytes, patch)
2014-04-15 05:30 UTC, Jia-Shiun Li 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jia-Shiun Li 2014-04-15 05:30:00 UTC 
x11-servers/xorg-server looks fine without MAKE_JOBS_UNSAFE.


jsli@4cbsd:/mnt/xorg-server # sysctl kern.smp.cpus hw.model
kern.smp.cpus: 4
hw.model: Intel(R) Core(TM) i5-3450 CPU @ 3.10GHz
jsli@4cbsd:/mnt/xorg-server # time make -DBATCH MAKE_JOBS_NUMBER=64
....
gmake[2]: Nothing to be done for `all-am'.
gmake[2]: Leaving directory `/mnt/xorg-server/work/xorg-server-1.12.4'
gmake[1]: Leaving directory `/mnt/xorg-server/work/xorg-server-1.12.4'
111.129u 22.940s 0:56.52 237.1% 32590+341k 0+8io 0pf+0w
jsli@4cbsd:/mnt/xorg-server # df -h /mnt
Filesystem    Size    Used   Avail Capacity  Mounted on
tmpfs         1.0G    116M    908M    11%    /mnt
jsli@4cbsd:/mnt/xorg-server #

Fix: Remove the line 'MAKE_JOBS_UNSAFE=yes'. Trivial patch is attached.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-15 05:30:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2014-04-15 18:56:46 UTC 
Can you please provide the actual error?
Regards!
-- 
Niclas Zeising
Comment 3 Jia-Shiun Li 2014-04-16 02:47:59 UTC 
Hi Niclas,

this is not a bug thus no error. It is an attempt to mark this ports
as jobs-safe. There was no error in my test and it indeed sped up
compilation. If no other concerns, this can make port build faster.

Regards,

On Wed, Apr 16, 2014 at 1:56 AM, Niclas Zeising <zeising@freebsd.org> wrote:
> Can you please provide the actual error?
> Regards!
> --
> Niclas Zeising
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2014-04-16 18:15:15 UTC 
On 04/16/14 03:47, Jia-Shiun Li wrote:
> Hi Niclas,
> 
> this is not a bug thus no error. It is an attempt to mark this ports
> as jobs-safe. There was no error in my test and it indeed sped up
> compilation. If no other concerns, this can make port build faster.
> 

Apologies, I thought the error was the opposite.  I'll look into making
this jobs safe.
Regards!
-- 
Niclas Zeising
Comment 5 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2014-12-23 23:50:32 UTC 
This is fixed in r374982.