Bug 188974 - [PATCH] archivers/star - reverse depreciation due to patch 188472 which fixes devel/smake
Summary: [PATCH] archivers/star - reverse depreciation due to patch 188472 which fixes...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 21:50 UTC by Chris Hutchinson
Modified: 2016-02-11 16:24 UTC (History)
1 user (show)

See Also:


Attachments
PR_188974.diff (514 bytes, patch)
2014-04-24 22:08 UTC, Chris Hutchinson
no flags Details | Diff
PR_188974.diff.shar (2.94 KB, application/octet-stream)
2014-05-15 02:19 UTC, Chris Hutchinson
no flags Details
patch to revive archivers/star (svn diff) (3.40 KB, patch)
2016-02-06 01:32 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
build log for archivers/star (56.46 KB, text/plain)
2016-02-06 01:35 UTC, Chris Hutchinson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2014-04-24 21:50:00 UTC
archivers/star is marked for removal because of broken devel/smake.
patch ports/188472 appears to correct the problems. As such; this pr(1)
provides a patch(1) to reverse removal of archivers/star and request
maintainership of archivers/star. I am also going to attempt to
"modernize" star(1) to use a "current" make(1) - GCC, CLANG, etc...

Patch to follow shortly, as attachment.

--Chris

Fix: 

Apply the patch ports/188472, then apply the one attached here.
How-To-Repeat: attempt to make archivers/star w/o the patch referenced above.
Comment 1 Chris Hutchinson 2014-04-24 22:08:50 UTC
> Thank you very much for your problem report.
> It has the internal identification `ports/188974'.
> The individual assigned to look at your
> report is: freebsd-ports-bugs.
>
> You can access the state of your problem report at any time
> via this link:
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=188974
>
>>Category:       ports
>>Responsible:    freebsd-ports-bugs
>>Synopsis:       [PATCH] archivers/star - reverse depreciation due to patch 188472 which
>> fixes devel/smake
>>Arrival-Date:   Thu Apr 24 20:50:00 UTC 2014
>
Please find patch(1) PR_188974.diff attached.
This patch addresses (reverses) the intent to DEPRECATE archivers/star.
It DEPENDS on ports/188472 to have already been applied to devel/smake.
This patch also requests maintainer-change. The request is based upon
my intent to update archivers/star to use modern/current configure/build tools.
This change will likely necessitate the need to "branch" archivers/star.
After this patch has been applied. I will create a new patch to address
staging.

Thank you for all your time, and consideration.

--Chris
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2014-05-12 11:51:10 UTC
I applied the changes in this PR and added now compulsory staging
support, but it does not build:
- somehow schily/mconfig.h cannot be found, although I added the path to
CFLAGS (see patch)
- predecessor errors in various include files

Full typescript and patch are available:
http://people.freebsd.org/~rene/star.log
http://people.freebsd.org/~rene/patches/star.diff

Can you look into this?

René
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2014-05-12 11:51:21 UTC
State Changed
From-To: open->feedback

Feedback for build problems requested 


Comment 4 Rene Ladan freebsd_committer freebsd_triage 2014-05-12 11:51:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Take
Comment 5 Chris Hutchinson 2014-05-15 00:59:29 UTC
> I applied the changes in this PR and added now compulsory staging
> support, but it does not build:
> - somehow schily/mconfig.h cannot be found, although I added the path to
> CFLAGS (see patch)
> - predecessor errors in various include files
>
> Full typescript and patch are available:
> http://people.freebsd.org/~rene/star.log
> http://people.freebsd.org/~rene/patches/star.diff
>
> Can you look into this?

Will Do.
Thank you very much, for all your attention to this, René.

--Chris

>
> René
>
Comment 6 Chris Hutchinson 2014-05-15 02:19:13 UTC
> I applied the changes in this PR and added now compulsory staging
> support, but it does not build:
> - somehow schily/mconfig.h cannot be found, although I added the path to
> CFLAGS (see patch)
> - predecessor errors in various include files
>
> Full typescript and patch are available:
> http://people.freebsd.org/~rene/star.log
> http://people.freebsd.org/~rene/patches/star.diff
>
> Can you look into this?
>
> René
>
OK. Just finished. Created a Patch against head checked out today.
I also checked out devel/smake from head today, and built smake
from that.
The results are in;
Using the diff(1) attached. I was able to:
make
make install
make clean
make deinstall
All w/o issue -- SUCCESS! :)
Please test/commit the attached diff(1) when you get a chance.

Thank you very much, René.

--Chris
Comment 7 Rene Ladan freebsd_committer freebsd_triage 2014-05-19 20:42:54 UTC
This is (almost) identical to the patch I have and which fails because
devel/smake is still broken at runtime (see previous post, that is with
the most recent smake).

Anyway, Renato (CC'd) decided to remove devel/smake and dependent ports,
so I'm not sure what would be best now.

René
Comment 8 Chris Hutchinson 2014-05-19 21:40:21 UTC
> This is (almost) identical to the patch I have and which fails because
> devel/smake is still broken at runtime (see previous post, that is with
> the most recent smake).
>
> Anyway, Renato (CC'd) decided to remove devel/smake and dependent ports,
> so I'm not sure what would be best now.
>

Hello, René, and thank you for the update.
I've got to say, the news is rather disappointing. I spent some time
trying to coordinate this w/the smake patch, and ensuring everything
would work out correctly. Examining your make session, captured from
script(1). I could see, that in your case, it appeared that make, and
or, configure (can't remember which one, off the top of my head) stumbled
on some ANSI control sequences. I'm not sure why you received that type
of output. Because no such output was generated during my configure, or
make sessions.
What must be done to keep these 2 ports within the ports collection?
Am I to understand that I would also need to maintain devel/smake as
well? Or...?

Thank you again, for taking the time to respond.

--Chris


> René
>
Comment 9 Renato Botelho freebsd_committer freebsd_triage 2014-05-20 14:51:53 UTC
On May 19, 2014, at 16:42, René Ladan <rene@freebsd.org> wrote:

> This is (almost) identical to the patch I have and which fails because
> devel/smake is still broken at runtime (see previous post, that is with
> the most recent smake).
> 
> Anyway, Renato (CC'd) decided to remove devel/smake and dependent ports,
> so I'm not sure what would be best now.


Hello,

I didnt remove devel/smake, its still on ports.

I removed archivers/star, that was marked as deprecated and had expiration date set to May 12th.

If there is a fix, and someone volunteer to maintain the port, it can be re-added.
Comment 10 Rene Ladan freebsd_committer freebsd_triage 2014-06-23 10:04:08 UTC
Any news?

Note that devel/smake is indeed still in the Ports Tree, but last time I tried it, it wouldn't work properly.
Comment 11 Chris Hutchinson 2014-06-23 16:15:54 UTC
(In reply to Rene Ladan from comment #10)
> Any news?
> 
> Note that devel/smake is indeed still in the Ports Tree, but last time I
> tried it, it wouldn't work properly.

Hello, Rene, and thanks for the info.

I'm currently tracking RELENG_8, and RELENG_9. Which isn't ideal for
testing. I found 10 to be a bit too "wobbly". I hope to eventually track
RELENG_11. So am staging to roll forward a couple of my servers to 11
to create a better "dev" environment. I should be in a position to test
this soon. When I get there, I'll test against smake, as well as
possibly fmake. To see if either one proves to be a better choice in
the long run. Other suggestions welcome. :)

Thanks again.

--Chris
Comment 12 Rene Ladan freebsd_committer freebsd_triage 2016-01-10 15:24:40 UTC
Any news on this (almost 1.5 years)?
Comment 13 Chris Hutchinson 2016-01-11 20:32:59 UTC
(In reply to Rene Ladan from comment #12)
> Any news on this (almost 1.5 years)?

The patches currently attached to this pr(1)
need to be updated, in order to work.
I'm reworking them now, and will have updates in
~1/2 hour. As well as a requisite QA log.

--Chris
Comment 14 Chris Hutchinson 2016-01-11 21:14:10 UTC
(In reply to Chris Hutchinson from comment #13)
> (In reply to Rene Ladan from comment #12)
> > Any news on this (almost 1.5 years)?
> 
> The patches currently attached to this pr(1)
> need to be updated, in order to work.
> I'm reworking them now, and will have updates in
> ~1/2 hour. As well as a requisite QA log.
> 
> --Chris

OK. smake is complaining. So I may not be able to finish this
real soon. Feel free to try yourself, if you're in any kind
of hurry. :-)

--Chris
Comment 15 Rene Ladan freebsd_committer freebsd_triage 2016-01-11 21:22:22 UTC
I'm not in any hurry :) I was just browsing through old PRs that I picked up and found this one.
Comment 16 Chris Hutchinson 2016-02-06 01:32:51 UTC
Created attachment 166637 [details]
patch to revive archivers/star (svn diff)

This patch should cover everything necessary to
revive archivers/star

DONE!

Thanks!

currently maintained by ports@ -- implicit patch approval
Comment 17 Chris Hutchinson 2016-02-06 01:35:14 UTC
Created attachment 166638 [details]
build log for archivers/star

Build log to prove it all works! :)

Thanks!

--Chris
Comment 18 commit-hook freebsd_committer freebsd_triage 2016-02-11 16:23:24 UTC
A commit references this bug:

Author: rene
Date: Thu Feb 11 16:22:43 UTC 2016
New revision: 408689
URL: https://svnweb.freebsd.org/changeset/ports/408689

Log:
  archivers/star: revive port

  - update MASTER_SITES
  - modernize (staging, USES, manual pages, @sample)
  - add license information (CDDL + GPLv2)
  - regenerate patches (no content changes)
  - pass maintainer to submitter

  While here:
  - add USE_GCC=any to allow build on FreeBSD 10+

  PR:		188974
  Submitted by:	Chris Hutchinson (portmaster@BSDforge.com)

Changes:
  head/MOVED
  head/archivers/Makefile
  head/archivers/star/
  head/archivers/star/Makefile
  head/archivers/star/files/patch-rmt_Makefile
  head/archivers/star/files/patch-rmt_Makefile.man
  head/archivers/star/files/patch-star::Makefile
  head/archivers/star/files/patch-star::star.1
  head/archivers/star/files/patch-star_Makefile
  head/archivers/star/files/patch-star_star.1
  head/archivers/star/pkg-plist
Comment 19 Rene Ladan freebsd_committer freebsd_triage 2016-02-11 16:24:16 UTC
Committed with minor fixes:
- pkg-plist (sample file handling)
- added USE_GCC=any for FreeBSD 10+