Bug 189029 - [UPDATE] graphics/py-pillow to 2.4.0
Summary: [UPDATE] graphics/py-pillow to 2.4.0
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords:
: 191283 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-26 18:00 UTC by Olivier Duchateau
Modified: 2014-07-26 12:40 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (3.35 KB, patch)
2014-04-26 18:00 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau freebsd_committer freebsd_triage 2014-04-26 18:00:01 UTC
- Update to 2.4.0
- Adjust URL in pkg-descr file
- Add patch in order to support different localization of headers in graphics/openjpeg > 1.5.x (not in ports tree, it needs exp-run)

In Makefile post-patch target can be removed, because by default openjpeg installs header into openjpeg-2.0/ subdirectory, but on my own port (2.0.1), I follow the current pkg-plist (no subdirectory).

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-26 18:00:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->koobs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-08 12:10:50 UTC
(In reply to Olivier Duchateau from comment #0)
> - Update to 2.4.0
> - Adjust URL in pkg-descr file
> - Add patch in order to support different localization of headers in
> graphics/openjpeg > 1.5.x (not in ports tree, it needs exp-run)
> 
> In Makefile post-patch target can be removed, because by default openjpeg
> installs header into openjpeg-2.0/ subdirectory, but on my own port (2.0.1),
> I follow the current pkg-plist (no subdirectory).
> 
> Fix: Patch attached with submission follows:

Do you want to take this Olivier?
Comment 3 Olivier Duchateau freebsd_committer freebsd_triage 2014-06-08 21:43:31 UTC
(In reply to Kubilay Kocak from comment #2)
> (In reply to Olivier Duchateau from comment #0)
> > - Update to 2.4.0
> > - Adjust URL in pkg-descr file
> > - Add patch in order to support different localization of headers in
> > graphics/openjpeg > 1.5.x (not in ports tree, it needs exp-run)
> > 
> > In Makefile post-patch target can be removed, because by default openjpeg
> > installs header into openjpeg-2.0/ subdirectory, but on my own port (2.0.1),
> > I follow the current pkg-plist (no subdirectory).
> > 
> > Fix: Patch attached with submission follows:
> 
> Do you want to take this Olivier?

As maintainer or update this port ?
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-09 01:19:47 UTC
This change since it affects (improves) openjpegm and I won't be able to review it in full before Wednesday-ish. Happy for you to shepherd it in :)
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-23 05:38:25 UTC
*** Bug 191283 has been marked as a duplicate of this bug. ***
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-23 05:43:24 UTC
Olivier,

I see recent commits for OpenJPG 2.1 here: https://github.com/python-pillow/Pillow/commit/a1268441350ade01a8cea7893d06a8302a3d12d5

Do we want to pull these instead?
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-06-27 11:01:54 UTC
A commit references this bug:

Author: koobs
Date: Fri Jun 27 11:01:06 UTC 2014
New revision: 359494
URL: http://svnweb.freebsd.org/changeset/ports/359494

Log:
  graphics/py-pillow: Update to 2.4.0

  - Update to 2.4.0
  - Chase upstream repository name change
  - pkg-descr: Update WWW: URL

  Changes:

    https://github.com/python-pillow/Pillow/blob/2.4.0/CHANGES.rst

  PR:		189029
  Submitted by:	oliverd (with changes, minus openjpg patch)

Changes:
  head/graphics/py-pillow/Makefile
  head/graphics/py-pillow/distinfo
  head/graphics/py-pillow/pkg-descr
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-27 11:07:06 UTC
Olivier, I've updated Pillow to 2.4.0 minus the CHEESESHOP and OpenJPEG changes due to bug 191283

The rest is pending your review of recent commits upstream adding OpenJPEG support (see my previous comment)

I'd also like to see any patches to sources sent upstream (Issues or PRs, latter preferred), please let me know where you'd like to go with this.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-26 12:40:42 UTC
Please re-open this issue if the OpenJPEG changes are still relevant after the upstream changes mentioned in comment 6