Bug 189056 - [patch] print/hplip: hpijs PPDs incorrectly accept PDF input
Summary: [patch] print/hplip: hpijs PPDs incorrectly accept PDF input
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-27 18:30 UTC by Lawrence Chen
Modified: 2014-04-30 08:23 UTC (History)
0 users

See Also:

Attachments
patch (2.30 KB, patch)
2014-04-27 18:30 UTC, Lawrence Chen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2014-04-27 18:30:00 UTC 
	
	I original started working on the patch on April 9th, which included
	updating to 3.14.4, and fixing the LIB_DEPENDS for cups-base.  But, got
	distracted by life.

	But, I fixed some problems with the hpijs PPDs which I'm providing
	here.

	The problem is that the PPDs claim to be generated for cups-1.5, and
	claim that they can directly consume PDF input by foomatic-rip-hplip.

		*cupsFilter: "application/vnd.cups-postscript 100 foomatic-rip-hplip"
		*cupsFilter: "application/vnd.cups-pdf 0 foomatic-rip-hplip"

	In cups-1.6, support for printers capable of the direct consumption of
	PDF files was added.

	But, unlike foomatic-rip, foomatic-rip-hplip is only capable of
	accepting PS or text. (treating PDF as text, results in just he PDF
	header printing.)

Fix: This patch addresses the deprecation warning that foomatic-rip-hplip
	generates and patches all the PPD files.  The PPDs are uncompressed,
	the line containing "vnd.cups-pdf" is removed, and the file size
	line is updated and they are recompressed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-27 18:30:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->makc

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Max Brazhnikov freebsd_committer freebsd_triage 2014-04-30 08:23:18 UTC 
State Changed
From-To: open->closed

Fixed using different patch in svn r352549, thanks for report!