Bug 189382 - [PATCH] databases/mdbtools: fix build after r353029
Summary: [PATCH] databases/mdbtools: fix build after r353029
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 20:50 UTC by Rainer Hurling
Modified: 2014-05-06 09:28 UTC (History)
0 users

See Also:


Attachments
file.diff (906 bytes, patch)
2014-05-05 20:50 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2014-05-05 20:50:00 UTC
After 'fixing unixODBC vs libiodbc conflicts' by bapt@ [1], databases/mdbtools does not build anymore. It tries to find include/sql.h from databases/libiodbc, which does not exist any more.

As a quick fix I changed the dependency from databases/libiodbc to databases/unixODBC. This builds and works fine, but on some boxes it now could be necessary to change the configuration file for odbc connections.


The plan for the near future will be to find a solution to also get libiodbc to work again with mdbtools. On success, I would like to make a knob to choose between the both database lib dependencies.



[1] http://svnweb.freebsd.org/ports?view=revision&revision=353029

Fix: Patch attached with submission follows:
How-To-Repeat: Try to build databases/mdbtools 0.7.1_1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-05 20:50:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

sunpoet@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-05-06 08:32:22 UTC
Author: bapt
Date: Tue May  6 07:32:18 2014
New Revision: 353075
URL: http://svnweb.freebsd.org/changeset/ports/353075
QAT: https://qat.redports.org/buildarchive/r353075/

Log:
  Switch over to unixODBC to fix build after r353029
  
  PR:		ports/189382
  Submitted by:	Rainer Hurling <rhurlin@gwdg.de>

Modified:
  head/databases/mdbtools/Makefile

Modified: head/databases/mdbtools/Makefile
==============================================================================
--- head/databases/mdbtools/Makefile	Tue May  6 07:29:10 2014	(r353074)
+++ head/databases/mdbtools/Makefile	Tue May  6 07:32:18 2014	(r353075)
@@ -3,7 +3,7 @@
 
 PORTNAME=	mdbtools
 PORTVERSION=	0.7.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 MASTER_SITES=	https://github.com/brianb/mdbtools/archive/
 DISTNAME=	${PORTVERSION}
@@ -16,7 +16,7 @@ LICENSE=	GPLv2
 # To build man-pages
 BUILD_DEPENDS=	gawk:${PORTSDIR}/lang/gawk \
 		txt2man:${PORTSDIR}/textproc/txt2man
-LIB_DEPENDS=	libiodbc.so:${PORTSDIR}/databases/libiodbc
+LIB_DEPENDS=	libodbc.so:${PORTSDIR}/databases/unixODBC
 
 USES=		bison pkgconfig iconv
 USE_AUTOTOOLS=	libtool autoconf automake
@@ -25,7 +25,7 @@ USE_GNOME=	glib20
 WANT_GNOME=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-libiconv-prefix=${LOCALBASE} \
-		--with-iodbc=${LOCALBASE}
+		--with-unixodbc=${LOCALBASE}
 
 DOCS=		AUTHORS ChangeLog HACKING NEWS README TODO
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2014-05-06 09:28:24 UTC
State Changed
From-To: open->closed

Committed. Thanks!