Bug 190066 - [patch] lang/ruby19 (and lang/ruby20, lang/ruby21) fix
Summary: [patch] lang/ruby19 (and lang/ruby20, lang/ruby21) fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 14:00 UTC by alex
Modified: 2014-08-30 21:10 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (927 bytes, patch)
2014-05-21 14:00 UTC, alex
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alex 2014-05-21 14:00:00 UTC
Makefile was missing ${STAGEDIR} for source of find commands for ${RUBY_RIDIR}.
This would manifest as a problem in one of two ways:

1. If actual ${RUBY_RIDIR} contained leftover directories and files, a bunch
of error messages like this would be emitted:
pkg-static: Plist error, directory listed as a file: /usr/local/share/ri/1.9/system/ACL/ACLList
pkg-static: Plist error, directory listed as a file: /usr/local/share/ri/1.9/system/ACL/ACL


2. If actual ${RUBY_RIDIR} non-existent or empty, then find command would not
actually do anything, i.e., not add anything to the ${TMPPLIST}, since it's
operating out of the real ${RUBY_RIDIR} rather than the staging directory version.
This in turn makes scenario #1 likely to happen since a deinstall won't clean up these files.

I also cleaned up a few of the many warnings emitted. The created.rid files were reported as
orphaned. I believe these should either be deleted from the stage directory before packaging,
or else included as part of the plist. I opted for the latter, as it seems like these files
are harmless and probably actually desired, especially in ${RUBY_SITERIDIR}, if I understand
the purpose of these files correctly.

Although these fixes are shown for lang/ruby19 Makefile, it appears lang/ruby20
and lang/ruby21 need the same fixes.

How-To-Repeat: 
Problem can be demonstrated by trying to package the port when the ${RUBY_RIDIR} has contents
leftover from a previous install.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-21 14:00:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ruby

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Steve Wills freebsd_committer freebsd_triage 2014-08-03 04:21:16 UTC
Hi,

Could you please take a look at the latest patch for bug 189646 and see if it fixes the issue for you?

Thanks,
Steve
Comment 3 alex 2014-08-05 18:58:36 UTC
Hi Steve,

The problem I reported had to do with the dynamic plist generation for the RIDIR files. It looks like you've yanked this out and replaced it with static plist instead. So yes, I believe your patch addresses this problem.

Thanks,

Alex
Comment 4 Steve Wills freebsd_committer freebsd_triage 2014-08-30 21:10:58 UTC
Should be fixed by r366678, please let us know if not.