Bug 190166 - net/samba41 rc script doesn't follow custom smb.conf
net/samba41 rc script doesn't follow custom smb.conf
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Timur I. Bakeyev
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-24 10:40 UTC by freebsd
Modified: 2014-10-05 22:03 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (741 bytes, patch)
2014-05-24 10:40 UTC, freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2014-05-24 10:40:00 UTC
	When you define a custo smb.conf, the testparm_command silently
ignores that file since the parameters are passed wrong, so compile time
default will be used.

How-To-Repeat: 	Define 'samba_server_config="/usr/local/etc/smb_instance1.conf"'
in /etc/rc.conf and intentionally include a mistake in custom conf file
before starting samba. Samba will start even testparm fisrt should look for
mistakes, but it doesn't check the same config file that will be used by the
daemons (that part is perfectly working in samba_server.in).
Comment 1 Edwin Groothuis freebsd_committer 2014-05-24 18:09:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->timur

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 commit-hook freebsd_committer 2014-06-23 18:48:27 UTC
A commit references this bug:

Author: timur
Date: Mon Jun 23 18:47:51 UTC 2014
New revision: 358993
URL: http://svnweb.freebsd.org/changeset/ports/358993

Log:
  Security update for Samba 3.6, 4.0 and 4.1.

  PR:		190166
  Security:	CVE-2014-0244
  		CVE-2014-3493
  		CVE-2014-0239
  		CVE-2014-0178

Changes:
  head/net/samba36/Makefile
  head/net/samba36/distinfo
  head/net/samba4/Makefile
  head/net/samba4/distinfo
  head/net/samba4/files/patch-buildtools__wafadmin__Tools__config_c.py
  head/net/samba4/files/samba_server.in
  head/net/samba41/Makefile
  head/net/samba41/distinfo
  head/net/samba41/files/patch-buildtools__wafadmin__Tools__config_c.py
  head/net/samba41/files/samba_server.in
Comment 3 Harald Schmalzbauer 2014-06-27 17:37:53 UTC
I originally sent this as gnats (via send-pr). Wondered why my local patch didn't apply to 4.1.9… Thanks for commiting!
Do I have to care about the gnats PR?

Thanks,

-Harry