Bug 190209 - [PATCH] unbreak mail/courier build for FreeBSD 10 and HEAD
Summary: [PATCH] unbreak mail/courier build for FreeBSD 10 and HEAD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-25 20:20 UTC by bsd
Modified: 2014-07-02 21:58 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (519 bytes, patch)
2014-05-25 20:20 UTC, bsd 		no flags Details | Diff
Patch to address build breakage, staging, and remove interactivity (30.82 KB, patch)
2014-06-30 21:53 UTC, bsd 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bsd 2014-05-25 20:20:00 UTC 
Currently building mail/courier on releases with default compiler switched to clang fails. Attached simple patch is a workaround for that.

How-To-Repeat: Try to build mail/courier on 10.0-RELEASE or newer
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-05-25 22:17:17 UTC 
State Changed
From-To: open->feedback

Please provide a patch that also fixes staging. And 0.73.1 instead of 
0.65 would be very nice 8-)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-06-20 18:05:34 UTC 
bsd@,
I hate to pile on, but we are making a push to eliminate interactive ports.  Can courier be converted to a regular port?  What's the technical difficulty in this, or what's the reason for the interactive requirement?
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-30 12:44:06 UTC 
Milan, what is the status for staging?  I would also like to know about interactive status.  Unstaged ports are going to be deprecated at some point soon, making the interactive issue a moot point.

At some point the lack of feedback could result in a maintainer reset too, so please respond quickly so we know you are still interested in the port.
Comment 4 bsd 2014-06-30 21:53:15 UTC 
Created attachment 144300 [details]
Patch to address build breakage, staging, and remove interactivity

This patch is still work in progress, but should address current issues:
- should build on 10 and 11 systems
- should support staging
- should remove issue with interactive port
There are some unexpected changes in file ownership, but they seem not to affect functionality.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-07-02 21:06:29 UTC 
stage support doesn't seem to be correct wrt to man pages:
https://redports.org/~jmarino/20140702204601-3744-220391/courier-0.65.3_1.log
https://redports.org/~jmarino/20140702204601-3744-220390/courier-0.65.3_1.log

I'm looking to see if there's an obvious fix but staging is busted out of the box.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-07-02 21:15:59 UTC 
hold on, this may be an error on my part.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-07-02 21:52:44 UTC 
A commit references this bug:

Author: marino
Date: Wed Jul  2 21:52:12 UTC 2014
New revision: 360268
URL: http://svnweb.freebsd.org/changeset/ports/360268

Log:
  mail/courier: Unbreak F10+, add stage support and remove interactivity

  PR:		190209
  Submitted by:	maintainer (Milan Obuch)
  Verified by:	Redports 8x pass

Changes:
  head/mail/courier/Makefile
  head/mail/courier/Makefile.man
  head/mail/courier/files/pkg-install.in
  head/mail/courier/files/pkg-message.in
  head/mail/courier/pkg-plist
Comment 8 John Marino freebsd_committer freebsd_triage 2014-07-02 21:58:38 UTC 
I had to patch with -p1 to get the port correctly patched.  It passed redports, but I noticed OSVERSION was used without OPSYS, so I modified this line.