Bug 190575 - New port: www/dddbl
Summary: New port: www/dddbl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-03 14:35 UTC by Torsten Zühlsdorff
Modified: 2014-08-08 15:34 UTC (History)
1 user (show)

See Also:


Attachments
file.shar (2.29 KB, application/x-shar)
2014-06-03 14:35 UTC, Torsten Zühlsdorff
no flags Details
Update of latest Patch - fix download source (2.48 KB, patch)
2014-08-04 09:57 UTC, Torsten Zühlsdorff
no flags Details | Diff
Fixed Patch to create new port (2.32 KB, patch)
2014-08-07 15:52 UTC, Torsten Zühlsdorff
no flags Details | Diff
Skip unneeded DISTFILES (2.27 KB, patch)
2014-08-08 08:13 UTC, Torsten Zühlsdorff
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2014-06-03 14:35:22 UTC
Created attachment 143335 [details]
file.shar

Adds the new port www/dddbl. This is a definition driven database layer for PHP. 

Because of a problem i had renamed the .shar file into .shar.txt. Neverless its a shar file!

Fix:
Patch attached with submission follows:
Comment 1 Torsten Zühlsdorff 2014-08-04 09:57:01 UTC
Created attachment 145334 [details]
Update of latest Patch - fix download source

Meanfile the download path of the source has changed. Corrected the Makefile and upload the complete new port definition.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-07 10:25:09 UTC
FYI, the shar had a zero-byte file in the directory..
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-07 10:28:41 UTC
This is ominous:

root@Niner:/home/marino/svnhub/freebsd-ports/www/dddbl # portlint
WARN: /usr/home/marino/svnhub/freebsd-ports/www/dddbl/pkg-descr: includes lines
that exceed 80 characters.
FATAL: /usr/home/marino/svnhub/freebsd-ports/www/dddbl/pkg-descr: contains a URL
 but no "WWW:"
FATAL: Makefile: [2]: header should be followed by $FreeBSD$.
FATAL: Makefile: no $FreeBSD$ line in comment section.
WARN: Makefile: use of DISTFILES with single file discouraged. distribution file
name should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: Consider defining LICENSE.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing th
em.
3 fatal errors and 4 warnings found.


Can you take this back, fix the portlint errors *AND* also show some verification, In order of preference, examples of what I'm looking for are:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) "make check-plist" followed by "make stage-qa" output
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-07 10:29:21 UTC
back to heap...
Comment 5 Torsten Zühlsdorff 2014-08-07 15:52:16 UTC
Created attachment 145449 [details]
Fixed Patch to create new port
Comment 6 Torsten Zühlsdorff 2014-08-07 15:54:29 UTC
I'm sorry for the bad qa. :(

Here we go with the new patch:

# make check-plist && make stage-qa
===>   dddbl-2.0.1 depends on file: /usr/local/sbin/pkg - found
=> dddbl-2.0.1.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch http://www.dddbl.de/dddbl-versions/dddbl-2.0.1.tar.bz2
dddbl-2.0.1.tar.bz2                           100% of 8236  B 1167 kBps 00m00s
===> Fetching all distfiles required by dddbl-2.0.1 for building
===>  Extracting for dddbl-2.0.1
=> SHA256 Checksum OK for dddbl-2.0.1.tar.bz2.
===>  Patching for dddbl-2.0.1
===>  Configuring for dddbl-2.0.1
===>  Staging for dddbl-2.0.1
===>   dddbl-2.0.1 depends on file: /usr/local/include/php/main/php.h - found
===>   Generating temporary packing list
/bin/mkdir -p /usr/ports/www/dddbl/work/stage/usr/local/share/dddbl
(cd /usr/ports/www/dddbl/work/dddbl2 && /bin/sh -c '(/usr/bin/find -d $0 $2 | /usr/bin/cpio -dumpl $1 >/dev/null  2>&1) &&  /usr/sbin/chown -Rh root:wheel $1 &&  /usr/bin/find -d $0 $2 -type d -exec chmod 755 $1/{} \; &&  /usr/bin/find -d $0 $2 -type f -exec chmod 444 $1/{} \;' -- . /usr/ports/www/dddbl/work/stage/usr/local/share/dddbl)
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====> Running Q/A tests (stage-qa)


portlint says:

# portlint
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: Consider defining LICENSE.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
0 fatal errors and 3 warnings found.

But i didn't see how to not use DISTFILES with the given naming.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-07 16:03:21 UTC
by setting DISTNAME perhaps?
DISTFILES is calculated based on DISTNAME.
Comment 8 Torsten Zühlsdorff 2014-08-08 08:13:45 UTC
Created attachment 145507 [details]
Skip unneeded DISTFILES

-.- Indeed... i'm sorry.

Patch updated.

QA:

 # make check-plist && make stage-qa
===>   dddbl-2.0.1 depends on file: /usr/local/sbin/pkg - found
=> dddbl-2.0.1.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch http://www.dddbl.de/dddbl-versions/dddbl-2.0.1.tar.bz2
dddbl-2.0.1.tar.bz2                           100% of 8236  B 1334 kBps 00m00s
===> Fetching all distfiles required by dddbl-2.0.1 for building
===>  Extracting for dddbl-2.0.1
=> SHA256 Checksum OK for dddbl-2.0.1.tar.bz2.
===>  Patching for dddbl-2.0.1
===>  Configuring for dddbl-2.0.1
===>  Staging for dddbl-2.0.1
===>   dddbl-2.0.1 depends on file: /usr/local/include/php/main/php.h - found
===>   Generating temporary packing list
/bin/mkdir -p /usr/ports/www/dddbl/work/stage/usr/local/share/dddbl
(cd /usr/ports/www/dddbl/work/dddbl2 && /bin/sh -c '(/usr/bin/find -d $0 $2 | /usr/bin/cpio -dumpl $1 >/dev/null  2>&1) &&  /usr/sbin/chown -Rh root:wheel $1 &&  /usr/bin/find -d $0 $2 -type d -exec chmod 755 $1/{} \; &&  /usr/bin/find -d $0 $2 -type f -exec chmod 444 $1/{} \;' -- . /usr/ports/www/dddbl/work/stage/usr/local/share/dddbl)
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====> Running Q/A tests (stage-qa)

root@hera:/usr/ports/www/dddbl # portlint
WARN: Makefile: Consider defining LICENSE.
0 fatal errors and 1 warning found.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-08 08:36:40 UTC
You're forgiven.  :)
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-08-08 15:33:46 UTC
A commit references this bug:

Author: marino
Date: Fri Aug  8 15:33:05 UTC 2014
New revision: 364367
URL: http://svnweb.freebsd.org/changeset/ports/364367

Log:
  Add new port www/dddbl

  PR:		190575
  Submitted by:	Torsten Zuehlsdorff

       ================================================================

  DDDBL is a Definition Driven DataBase Layer written in PHP. It uses PDO to
  support the work on all supported database systems and eases the handling
  of the query-results.

Changes:
  head/www/Makefile
  head/www/dddbl/
  head/www/dddbl/Makefile
  head/www/dddbl/distinfo
  head/www/dddbl/pkg-descr
  head/www/dddbl/pkg-plist
Comment 11 John Marino freebsd_committer freebsd_triage 2014-08-08 15:34:47 UTC
Thanks!