Created attachment 143440 [details] patch-src-sdl-expr.cpp Currently emulators/visualboyadvance-m does not build. Fix: Add the attached patch to emulators/visualboyadvance-m/files.
Nicole (root@cooltrainer), Do you approve this patch? Your port is busted almost everywhere currently, according to portsmon: http://portsmon.freebsd.org/portoverview.py?category=emulators&portname=visualboyadvance-m Actually, I see two consecutive maintainer timeouts, which the last sighting back in 2011. Please respond quickly otherwise this port will be reset when the patch is applied. Thanks, John
I have a more extensive update patch in #189647 that rotted a little since the time I submitted it and needs to be fixed to the current ports tree this week. That seems to happen a lot when all my PRs take weeks to months to be acknowledged (lookin' at you, #186860!).
ok, [new port] PRs are pretty much on the back burner. They are getting postponed en-masse in favor of staging and needed fixes. Updates to new versions are suffering too, but not as much as "new ports". Be that as it may, #189647 was responded to 6 days ago. It looks like Martin just wants the patch set regenerated (not an unreasonable request). The question is, will moving to version r1231 fix the build on all platforms? If yes, regenerate the patch for Martin. If he doesn't get to it within 1 week, I'll take the patch and commit it myself. deal? Thanks for responding to my ping, btw. John
No worries. I'll get it done this weekend, but I deleted the tree where I made the patch and need to put it back together from the reject diff. I just disabled SDL in my r1231 since I was also attempting to fix their std namespace collisions but found that broke elsewhere when trying to play it.
This patch is integrated into my r1231 update at #189647. Thanks submitter!
Incorporated.