Bug 190954 - [patch] Added stage support to www/tikiwiki
Summary: [patch] Added stage support to www/tikiwiki
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
Depends on:
Reported: 2014-06-12 02:28 UTC by joe
Modified: 2014-06-13 20:09 UTC (History)
1 user (show)

See Also:

Added stage support to tikiwiki (893 bytes, text/plain)
2014-06-12 02:28 UTC, joe
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-06-12 02:28:00 UTC
Created attachment 143698 [details]
Added stage support to tikiwiki

Added stage support to www/tikiwiki.
Comment 1 John Marino freebsd_committer 2014-06-13 16:48:34 UTC
This port built cleanly, but when I looked closely I spotted some problems:

1) The installation is muted with (@). That was in the original makefile and it's wrong
2) The "-" prefix for mkdir command is unnecessary.  It will never fail
3) The "cp -R" technique is not allowed, use COPYTREE for entire directory copy
4) The ownership / group stuff needs to happen in the pkg-plist, not in stage.  Again this was in the original but it needed to be changed and it wasn't.
Comment 2 John Marino freebsd_committer 2014-06-13 16:58:00 UTC
the plist is over 15,000 lines, 1.1Mb!
Seems to be a candidate for autogenerated plist
Comment 3 John Marino freebsd_committer 2014-06-13 17:18:29 UTC
This port has a custom extract target, and the arguments are -yxf.
-y is for tar.bz2, but this is a tar.gz file!

Apparently tar is just handling it, but it's really an error.
And I doubt it needs a custom target.
Comment 4 commit-hook freebsd_committer 2014-06-13 20:07:09 UTC
A commit references this bug:

Author: marino
Date: Fri Jun 13 20:06:35 UTC 2014
New revision: 357720
URL: http://svnweb.freebsd.org/changeset/ports/357720

  www/tikiwiki: Add Stage support, switch to autogen pkg list

  PR:		190954
  Submitted by:	Joe Benden

  The stage PR worked, but there were existing problems that weren't fixed,
  such as muted install commands, "cp -r" instead of install macros, the use
  of "-" prefix on commands that won't fail.  A list of additional, "while
  we are here changes":

    * 16,000+ line, 1.1Mb pkg-plist removed, autogen instead
    * Remove now-unnecessary x-generate-plist maintainer target
    * Remove PLIST_SUB lines
    * Remove unnecessary roll-your-own extract target.  Leave one original
      deletion as a post-extract target
    * Use COPYTREE_SHARE instead of "cp -r"
    * move CHOWN operations to pkg-plist generation