Bug 191037 - sysutils/ldap-account-manager version update
Summary: sysutils/ldap-account-manager version update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 20:24 UTC by basil
Modified: 2014-06-22 19:51 UTC (History)
1 user (show)

See Also:

Attachments
lam46_1 (3.43 KB, patch)
2014-06-22 07:32 UTC, basil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description basil 2014-06-14 20:24:30 UTC 
version update

Fix:
diff -ruN /usr/ports/sysutils/ldap-account-manager/Makefile /root/ldap-account-manager/Makefile
--- /usr/ports/sysutils/ldap-account-manager/Makefile   2014-04-20 09:36:26.000000000 +0300
+++ /root/ldap-account-manager/Makefile 2014-06-14 23:07:48.956836001 +0300
@@ -1,7 +1,7 @@
 # $FreeBSD: head/sysutils/ldap-account-manager/Makefile 351612 2014-04-20 06:36:26Z rm $
 
 PORTNAME=      ldap-account-manager
-PORTVERSION=   4.5
+PORTVERSION=   4.6
 CATEGORIES=    sysutils www
 MASTER_SITES=  SF/${SHORTNAME}/LAM/${PORTVERSION}
 
diff -ruN /usr/ports/sysutils/ldap-account-manager/distinfo /root/ldap-account-manager/distinfo
--- /usr/ports/sysutils/ldap-account-manager/distinfo   2014-04-20 09:34:11.000000000 +0300
+++ /root/ldap-account-manager/distinfo 2014-06-14 23:08:02.638832621 +0300
@@ -1,2 +1,2 @@
-SHA256 (ldap-account-manager-4.5.tar.bz2) = 7652475905fdfb27b40feaa6c0dc39dc78caa6465e1654539799f5c40ae8f714
-SIZE (ldap-account-manager-4.5.tar.bz2) = 11729338
+SHA256 (ldap-account-manager-4.6.tar.bz2) = df9f267c33ddce52e598ac540fecce0f3dc2546a0cc339f8200f39a1baa411f1
+SIZE (ldap-account-manager-4.6.tar.bz2) = 12358788
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-06-15 02:34:44 UTC 
Maintainer update.  Fix Synopsis.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-20 12:50:39 UTC 
The plist looks wrong:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%WWWDIR%%/config/config.cfg
Error: Orphaned: %%WWWDIR%%/config/lam.conf
Comment 3 basil 2014-06-20 20:25:29 UTC 
yes, config's does't exist in package.

Please look in Makefile


CONFIGS= config.cfg lam.conf

.if !exists(${STAGEDIR}${WWWDIR}/config/${CONFIG})
<------>@${CP} ${STAGEDIR}${WWWDIR}/config/${CONFIG}_sample ${STAGEDIR}${WWWDIR}/config/${CONFIG}
.endif
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-20 21:03:28 UTC 
Then please fix either the Makefile or the plist, as I can't commit something that does not pass check-plist.

While at it, how about replacing those manual TMPPLIST manipulation with a separate pkg-plist using keywords such as @sample?
Comment 5 basil 2014-06-22 06:08:02 UTC 
http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html

Note:
The sample configuration files should always have the .sample suffix. If for some historical reason you cannot use the standard suffix, you can still use this construct:

But, I have files with name config.cfg_sample lam.conf_sample. How set ?
Comment 6 basil 2014-06-22 07:32:01 UTC 
Created attachment 144013 [details]
lam46_1

fixed config @sample in plist
Comment 7 basil 2014-06-22 07:35:35 UTC 
(In reply to Raphael Kubo da Costa from comment #4)
> Then please fix either the Makefile or the plist, as I can't commit
> something that does not pass check-plist.
> 
> While at it, how about replacing those manual TMPPLIST manipulation with a
> separate pkg-plist using keywords such as @sample?

I fix  plist
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-06-22 14:39:56 UTC 
A commit references this bug:

Author: rakuco
Date: Sun Jun 22 14:39:50 UTC 2014
New revision: 358807
URL: http://svnweb.freebsd.org/changeset/ports/358807

Log:
  - Update to 4.6.
  - Use the @sample helper for handling config files.

  PR:		191037
  Submitted by:	basil@vpm.net.ua (maintainer)

Changes:
  head/sysutils/ldap-account-manager/Makefile
  head/sysutils/ldap-account-manager/distinfo
Comment 9 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-22 14:40:51 UTC 
Committed, thank you.

I still don't get why you don't use a regular plist file instead of directly manipulating TMPPLIST, or why you don't use the port's autoconf infrastructure, though...
Comment 10 basil 2014-06-22 19:51:54 UTC 
(In reply to Raphael Kubo da Costa from comment #9)
> Committed, thank you.
> 
> I still don't get why you don't use a regular plist file instead of directly
> manipulating TMPPLIST, or why you don't use the port's autoconf
> infrastructure, though...

It's worked :) and not required many time for creating port update