Bug 191045 - databases/memcachedb: Stagify; cleanup
Summary: databases/memcachedb: Stagify; cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-15 01:20 UTC by Keith Gaughan
Modified: 2014-07-12 09:12 UTC (History)
3 users (show)

See Also:

Attachments
memcachedb.patch.txt (2.45 KB, patch)
2014-06-15 01:20 UTC, Keith Gaughan 		no flags Details | Diff
Switch BDB dependency to 4.8; fix LICENSE (2.46 KB, patch)
2014-06-15 01:42 UTC, Keith Gaughan 		no flags Details | Diff
Revised patch (plist issues) (2.44 KB, patch)
2014-06-28 06:54 UTC, Thomas Zander 		riggs: maintainer-approval?
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Gaughan 2014-06-15 01:20:12 UTC 
Created attachment 143786 [details]
memcachedb.patch.txt

This patch makes the port safe for staging.

It also sets the LICENSE, fixes a number of issues reported by portlint, fixes
the English up in pkg-descr and the comment, and makes the port depend on databases/db47 specifically as it will currently break if databases/db5 is installed and it tries to build against that.
Comment 1 Keith Gaughan 2014-06-15 01:42:31 UTC 
Created attachment 143787 [details]
Switch BDB dependency to 4.8; fix LICENSE

Apologies. I forgot to double-check the LICENSE line.

I also bumped the version of BDB it depends on up to 4.8, as the 4.7 port gives deprecation warnings, and I only noticed this after I purposely did a from-scratch install of the port.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2014-06-15 04:18:34 UTC 
Notify maintainer.
Comment 3 Keith Gaughan 2014-06-15 15:35:29 UTC 
If the maintainer doesn't reply, I'll also take over maintainership.
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2014-06-28 06:54:23 UTC 
Created attachment 144212 [details]
Revised patch (plist issues)

There is no need to handle the rc script via pkg-plist. USE_RC_SUBR does already take care of this.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-12 09:10:11 UTC 
A commit references this bug:

Author: riggs
Date: Sat Jul 12 09:09:45 UTC 2014
New revision: 361605
URL: http://svnweb.freebsd.org/changeset/ports/361605

Log:
  - Stagify
  - General cleanup
  - Add LICENSE
  - Bump required BDB version
  - Bump PORTREVISION
  - Update pkg-descr
  - Handle ownership flags via plist macros

  PR:		191045
  Submitted by:	Keith Gaughan <k@stereochro.me>
  Approved by:	mentors (implicit), maintainer (timeout)

Changes:
  head/databases/memcachedb/Makefile
  head/databases/memcachedb/pkg-descr
  head/databases/memcachedb/pkg-plist