Bug 191079 - ports-mgmt/portlint: request to remove single MASTER_SITES warning
Summary: ports-mgmt/portlint: request to remove single MASTER_SITES warning
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 08:52 UTC by John Marino
Modified: 2014-07-12 14:54 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2014-06-16 08:52:39 UTC
As briefly discussed on IRC last week, the portlint warning when MASTER_SITES only has one entry is not really a good one.

A single entry is not bad, especially if it's an alias for a mirror network.  Countless ports would return "looks fine" by portlint if not for this check.

Can we re-evaluate the value of this warning, if if confirmed that it's not something that should be checked, remove it?
Comment 1 John Marino freebsd_committer freebsd_triage 2014-06-26 10:48:57 UTC
Hi Joe,
What do you think?  Are you looking for a patch?  How do we move this PR along?
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2014-06-26 14:45:32 UTC
Sorry, I think this feel through the cracks on my last portlint push.  We do have whitelists for known CDNs, so I'd prefer not to just whitewash all single-MASTER_SITE ports.  Are there any known aliases that are missing from the whitelist?
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-26 16:37:11 UTC
I don't know that.  My position is that the rule is bad and should be unconditionally removed, and that opinion is shared.  The existence of aliases are one reason it's shared, but not the only reason.

Now, I don't know that it's a majority opinion or not.  I also don't know if there was some kind of equivalent vote down to add the rule either.  Maybe someone thought it was a great idea and added it without asking anyone, I don't know.

So I'm unclear how to proceed.   It seems pretty unpopular when I brought the topic up on IRC, which prompted me to write this bug report.
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2014-06-27 05:50:32 UTC
I'll take it to the people.  If the consensus is to kill it, it shall be killed.
Comment 5 Joe Marcus Clarke freebsd_committer freebsd_triage 2014-07-12 14:54:06 UTC
Fixed in 2.15.3.