Bug 191113 - [patch] Add missing dependency for devel/kdevelop-kde4
Summary: [patch] Add missing dependency for devel/kdevelop-kde4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 23:05 UTC by Kevin Zheng
Modified: 2014-06-21 18:58 UTC (History)
1 user (show)

See Also:

Attachments
Patch that adds the correct dependency (528 bytes, patch)
2014-06-16 23:05 UTC, Kevin Zheng 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2014-06-16 23:05:33 UTC 
Created attachment 143857 [details]
Patch that adds the correct dependency

devel/kdevelop-kde4 fails to build in poudriere with the following error:

In file included from /wrkdirs/usr/ports/devel/kdevelop-kde4/work/kdevelop-4.6.0/documentation/qthelp/kdevqthelp_automoc.cpp:5:
In file included from /wrkdirs/usr/ports/devel/kdevelop-kde4/work/kdevelop-4.6.0/documentation/qthelp/moc_qthelpproviderabstract.cpp:9:
/wrkdirs/usr/ports/devel/kdevelop-kde4/work/kdevelop-4.6.0/documentation/qthelp/qthelpproviderabstract.h:30:10: fatal error: 'QHelpEngine' file not found
#include <QHelpEngine>
         ^
1 error generated.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-20 18:18:09 UTC 
Are you using any special options? It built fine here on poudriere/11-amd64, and the pkg-fallout machines look fine too.
Comment 2 Kevin Zheng 2014-06-21 03:24:04 UTC 
I switched around *many* options while compiling KDE, so I don't think I'll be able to pinpoint it to any one specific option. In any case, if QHelpEngine is used in the port, it should be a direct dependency (instead of relying on dependent ports that may or may not require it).
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-21 18:55:30 UTC 
I don't disagree with that, my point is that without an easy way to reproduce the issue I might as well be just half-fixing the issue and miss another dependency somewhere.

In this case I'm going the nuclear way and depend on all Qt libraries I can see in the build system.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-06-21 18:57:47 UTC 
A commit references this bug:

Author: rakuco
Date: Sat Jun 21 18:57:04 UTC 2014
New revision: 358735
URL: http://svnweb.freebsd.org/changeset/ports/358735

Log:
  Explicitly depend on all Qt libraries linked by the build system targets.

  Stop pulling Qt dependencies implicitly via other ports, as this can be
  unreliable at times. Instead, bring in all Qt ports that the port links
  against.

  PR:		191113

Changes:
  head/devel/kdevelop-kde4/Makefile