Bug 191222 - x11-themes/icons-tango-extras fails configure
Summary: x11-themes/icons-tango-extras fails configure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-20 19:56 UTC by Sean Bruno
Modified: 2014-06-21 06:08 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2014-06-20 19:56:22 UTC
Not sure when this stopped working or why to be honest.  Neither x11-themes/icons-tango-extras nor icon-naming-utils has changed recently.  I can't quite see why its breaking down here, but here is my poudriere output:

===>   Returning to build of icons-tango-extras-0.1.0_5
===========================================================================
=======================<phase: lib-depends    >============================
===>   icons-tango-extras-0.1.0_5 depends on shared library: libatk-1.0.so - found (/usr/local/lib/libatk-1.0.so.0)
===>   icons-tango-extras-0.1.0_5 depends on shared library: libgdk_pixbuf-2.0.so - found (/usr/local/lib/libgdk_pixbuf-2.0.so.0)
===>   icons-tango-extras-0.1.0_5 depends on shared library: libglib-2.0.so - found (/usr/local/lib/libglib-2.0.so.0)
===>   icons-tango-extras-0.1.0_5 depends on shared library: libpcre.so - found (/usr/local/lib/libpcre.so.3)
===>   icons-tango-extras-0.1.0_5 depends on shared library: libpango-1.0.so - found (/usr/local/lib/libpango-1.0.so.0.3400.1)
===========================================================================
=======================<phase: configure      >============================
===>  Configuring for icons-tango-extras-0.1.0_5
===>   FreeBSD 10 autotools fix applied to /wrkdirs/usr/ports/x11-themes/icons-tango-extras/work/tango-icon-theme-extras-0.1.0/aclocal.m4
===>   FreeBSD 10 autotools fix applied to /wrkdirs/usr/ports/x11-themes/icons-tango-extras/work/tango-icon-theme-extras-0.1.0/configure
configure: loading site script /usr/ports/Templates/config.site
checking for a BSD-compatible install... /usr/bin/install -c -o root -g wheel
checking whether build environment is sane... yes
checking for gawk... (cached) /usr/bin/awk
checking whether gmake sets $(MAKE)... yes
checking how to create a ustar tar archive... (cached) /usr/bin/tar
checking for pkg-config... no
checking icon-naming-utils >= 0.6.0... no
configure: error: icon-naming-utils >= 0.6.0 is required to build
                 and install tango-icon-theme
===>  Script "configure" failed unexpectedly.
Please report the problem to flz@FreeBSD.org [maintainer] and attach the
"/wrkdirs/usr/ports/x11-themes/icons-tango-extras/work/tango-icon-theme-extras-0.1.0/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/x11-themes/icons-tango-extras
====>> Cleaning up wrkdir
===>  Cleaning for icons-tango-extras-0.1.0_5
build of /usr/ports/x11-themes/icons-tango-extras ended at Fri Jun 20 12:25:59 PDT 2014
build time: 00:00:53
!!! build failure encountered !!!
Comment 1 Sean Bruno freebsd_committer freebsd_triage 2014-06-20 23:04:47 UTC
Huh ... I guess it just needs a USES pkgconfig.  Odd that this never popped up before:

redports build before patch
https://redports.org/buildarchive/20140620221701-43018/

redports build after patch
https://redports.org/buildarchive/20140620225215-79404/

Patch:

Index: Makefile
===================================================================
--- Makefile	(revision 28230)
+++ Makefile	(working copy)
@@ -2,7 +2,7 @@
 
 PORTNAME=	icons-tango-extras
 PORTVERSION=	0.1.0
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	x11-themes
 MASTER_SITES=	http://tango.freedesktop.org/releases/ \
 		${MASTER_SITE_GENTOO}
@@ -18,7 +18,7 @@
 RUN_DEPENDS=	${LOCALBASE}/share/icons/Tango/16x16/actions/add.png:${PORTSDIR}/x11-themes/icons-tango
 
 GNU_CONFIGURE=	yes
-USES=	gmake
+USES=	gmake pkgconfig
 USE_GNOME=	intlhack
 INSTALLS_ICONS=	yes
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2014-06-20 23:35:09 UTC
Revision 358652 - (show annotations) (download)
Fri Jun 20 23:01:36 2014 UTC (13 minutes, 38 seconds ago) by marino
File MIME type: text/plain
File size: 785 byte(s)

x11-themes/icons-tango-extras: USES+= pkgconfig

This fixes configuration failure in poudriere.  While here, pet portlint.

Approved by:	general blanket
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-21 06:08:08 UTC
FWIW, I was not aware of this PR.  I found this problem and the solution on my own.  Nice coincidence for you!