FreeBSD Bugzilla – Bug 191413
[NEW PORT] multimedia/plexhometheater: Media center front-end for plexmediaserver
Last modified: 2014-08-23 12:55:09 UTC
Please add a new port for multimedia/plexhometheater (the media center front-end to plexmediaserver). This is a fork of XBMC and therefore has many similar dependencies.
I have got the port working here:
I could only get it to build with clang, so I have included the following in the Makefile for now:
There is one problem with the resulting executable which I have not yet tracked down: once installed you need to:
# sed -i.bak s/dll_fopen/fopen/g /usr/local/bin/system/ImageLib-x86_64.so
Before running the executable in X11, you first need to set the XBMC_HOME environment variable.
$ export XBMC_HOME=/usr/local/share/XBMC
After that it seems to work fine (tested on FreeBSD 10.0-RELEASE).
I don't think that is going to fly.
At the very least you need USES= compiler:<option>
You should get a committer help you sort this out and then resubmit an updated shar here. Maybe ask on ports@ mailing list for a volunteer?
Thanks for the feedback John. I found the problem that was preventing it building with GCC and have fixed it with a patch. I have removed the compiler requirements from the Makefile. Any other feedback?
(In reply to John Marino from comment #1)
> I don't think that is going to fly.
> At the very least you need USES= compiler:<option>
> You should get a committer help you sort this out and then resubmit an
> updated shar here. Maybe ask on ports@ mailing list for a volunteer?
sure, at the very least post an updated redports run results (8x).
Ideally, you would also attached a "poudriere testport" or "poudriere bulk -t" log because that will provide even more testing that redports.
Do that, and there will be high confidence in the submission, making it more likely to get picked up sooner.
Link to successful redports builds below.
Will work on poudriere tests (I don't yet have something to test on, but will work on it).
(In reply to John Marino from comment #3)
> sure, at the very least post an updated redports run results (8x).
> Ideally, you would also attached a "poudriere testport" or "poudriere bulk
> -t" log because that will provide even more testing that redports.
> Do that, and there will be high confidence in the submission, making it more
> likely to get picked up sooner.
Great! In the meantime, I think you've shown enough to merit a "patch-ready" status, but attach those logs if/when you get them.
er, well, no, attach the shar first. :)
Sorry, what is a shar?
(In reply to John Marino from comment #6)
> er, well, no, attach the shar first. :)
Never mind... Just saw it in the porters handbook
I am a very, very heavy Plex user, and I am thrilled to see a PHT port!
I'm going to commit this shortly with some small modifications. In particular, it wouldn't build (needed USES=pkgconfig) and wouldn't package (the .desktop file). Also, I have changed the COMMENT. While it is true, it also is not particularly descriptive and makes it harder to search for in places like freshports.org.
I am happy to handle future updates for this port; please Cc: me when you submit updates.
I'm going to leave this bug report open after commit pending this question: does this port truly require java? Java is a dealbreaker for many people, and it not required when I build it for my mac. Can java support be turned into an OPTION?
A commit references this bug:
Date: Thu Aug 21 16:56:01 UTC 2014
New revision: 365568
Add multimedia/plexhometheater, the frontend to the powerful
Plex media system.
Submitted by: firstname.lastname@example.org
Committed with a few more modifications:
- plexhometheater.sh had /usr/local hardcoded. Please look at the SUB_FILES and the .in file for how I solved it.
- You had some DOS-style line endings in one of your patches. Please, please run 'portlint -C' before submitting patches.
That said, seriously good work on this port! PHT is a massive program and I can only imagine how much work it was to get it all together.
Thank you so much Adam! This is infact my first ever port for FreeBSD, and you're right when you say it was a lot of work. I am very glad it has been committed and it hasn't all been for nothing!
I was had not yet submitted the shar file as I was still trying to work out a few more things:
1. Does it need to install the man file? The XBMC port has this.
2. Does it need to strip the binaries post-install or is this automatically handled?
3. I was trying to enable python support (similar to the archlinux build) by adding CMAKE_ARGS+= -DENABLE_PYTHON:BOOL=true. But it was giving me linking errors which I was still investigating.
As for using java, XBMC (which this software is based on) also uses java. Not sure if it is actually needed and why.
Also, I am trying to commit most of the patches upstream (mostly the TARGET_FREEBSD stuff). Will let you know how it goes.
(In reply to woodsb02 from comment #12)
> 1. Does it need to install the man file? The XBMC port has this.
In general, yeah it's better to install manpages than not. You can do so in post-install if you need to.
> 2. Does it need to strip the binaries post-install or is this automatically
It's being done automatically. Try building the port with make DEVELOPER=yes. As part of the stage-qa tests, it checks for unstripped libraries and binaries.
> 3. I was trying to enable python support (similar to the archlinux build) by
> adding CMAKE_ARGS+= -DENABLE_PYTHON:BOOL=true. But it was giving me linking
> errors which I was still investigating.
I had trouble with ENABLE_PYTHON on the macosx build too.
> As for using java, XBMC (which this software is based on) also uses java.
> Not sure if it is actually needed and why.
I run PHT on my macs without java and there is no trouble. I commented out the java stuff and the port happily built without java. Personally I would recommend leaving the java stuff out entirely, or putting into an OPTION that is off by default.
I'm closing this PR. You have my recommendation: disable java by default in a future revision or patch.
Thanks again for creating this port.