Created attachment 144218 [details]
Patch for DoubleCMD dependencies

Solved! I can build DoubleCMD listening to the actual version of Lazarus, and resolving minimum requirements of dependencies. It works OK for me.

Replacing previous patch for this other.

Created attachment 144223 [details]
Patch2 for DoubleCMD dependencies

Comment 4 Mark Linimon 2014-07-04 01:13:56 UTC

Notify maintainer.

Hello Toni,

Thanks for your contributions, but I am afraid I must decline your patch.

There is a good reason why a port has both buildtime and runtime dependencies:

Usually builtime dependencies are formed by a large chain of ports which are not needed to run the application. Installing them adds an unnecessary bloat to your system.

By separating them, a user who uses binary packages will just have the minimum necessary ones to run the application.


With your patch, installing Double Commander alone would also install all Lazarus and Free Pascal dependencies, which are not needed by most people.


In any case, you have several ways to avoid the problems you are having:

1) Manually install Lazarus, so autoremove won't deinstall it. As an alternative, use this command if Lazarus is already installed:
# pkg set -A 0 editors/lazarus
(It will mark Lazarus port as non-automatic)

2) Use official binary packages, this way you won't need to build anything, and your system will be clean of builtime dependencies.

3) Use an automated port building system, like Poudriere, so it creates packages of every dependency which can be reused later when compiling Double Commander again. It will also prevent from leaving you with a broken system by ports which fail to build.


If you need help with any of the mentioned methods, you can ask me personally by mail (in spanish if you prefer), and I will assist you.



For the second part of your patch, AFAIK the use of != assignment in Makefiles is discouraged.

It is true Double Commander doesn't require latest Lazarus, but the port system is meant to be used in a consistent way, and using a different port tree revision for a dependency can result in breakage as you have already seen in the past.

You should always build doublecmd port with the equivalent lazarus version in the ports.

Thanks bbtruk. I didn't know the pkg set and the automatic/nonautomatic flag (I must document more!). And yes, if installing binaries call to lazarus and all this dependencies, then doesn't the best solution.

But, when I update the ports tree and only I will update doublecmd, why I'm forced to update the lazarus too if it doesn't needed? Ok if the port tree is consistent but, if it doesn't need for run (only for build), then I think that  Lazarus maximum update isn't necessary.

Saludos!

Because each revision in the ports tree works as a single unit. Things may change in a port between revisions, and every other port which has a dependency on it has to be aware of this change.

As an example, you can see that lazarus port recently changed its install location from /usr/local/share/lazarus/ (until v1.2) to /usr/local/share/lazarus-{VERSION}/ (starting from v1.2.4).

Now, imagine you have lazarus v1.2 installed and try to update doublecmd port (to v0.5.10_1) without updating lazarus port first. Doublecmd port would be unable to find your lazarus installation directory (it would search in /usr/local/share/lazarus-{VERSION}/ instead of /usr/local/share/lazarus/) and the build process would fail.

This is the reason why updating a single port without its dependencies is a bad idea.

Ok, I understand.

Thanks very much.

Comment 9 Adam Weinberger 2014-07-10 22:17:52 UTC

Has this issue been satisfactorily resolved for both the submitter and maintainer? Can this PR be closed?

Yes, unless Toni has anything else to add, this PR can be closed.

Thanks!

Yes, sorry!