Bug 191514 - print/cups-base does not install files for web UI if OPTIONS_UNSET+=DOCS specified in make.conf
Summary: print/cups-base does not install files for web UI if OPTIONS_UNSET+=DOCS spec...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 15:08 UTC by Dmitry Afanasiev
Modified: 2016-03-05 16:30 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Afanasiev 2014-06-30 15:08:12 UTC 
print/cups-base does not have configurable option DOCS, but silently affected by OPTIONS_UNSET+=DOCS in make.conf: in this case port does not install files for Web UI (index.html, cups.css and another) into /usr/local/share/doc/cups
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-30 15:13:19 UTC 
Which files from the pkg-plist are you expecting to be installed but aren't ?
Comment 2 Dmitry Afanasiev 2014-06-30 15:54:06 UTC 
All files from this output not installed:
grep %%PORTDOCS%%%%DOCSDIR%% /usr/ports/print/cups-base/pkg-plist

Directory /usr/local/share/doc/cups also is not created.

As workaround I used this in make.conf:
.if ${.CURDIR} != "/usr/ports/print/cups-base"
OPTIONS_UNSET+=DOCS EXAMPLES HELP IPV6 HAL GNUTLS AALIB
.endif

But, IMHO, it's looks ugly.
Comment 3 Johannes Jost Meixner freebsd_committer freebsd_triage 2014-06-30 15:58:03 UTC 
Your workaround looks okay-ish, yet here's a better way to do it:

print_cups-base_SET+= DOCS
Comment 4 Dmitry Afanasiev 2014-06-30 17:48:23 UTC 
Omg.
I rebuilded this port which this make.conf:
OPTIONS_UNSET+=DOCS EXAMPLES HELP IPV6 HAL GNUTLS AALIB
print_cups-base_SET+=DOCS
print_cups-base_SET_FORCE+=DOCS

And against got NO /usr/local/share/doc/cups directory.

I'm loser? :(

Also, is correct location for this directory? /usr/local/share/doc/cups content really is not documentation.
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2014-08-03 19:50:01 UTC 
Can you give a list of which files are required for the WEB UI? Those particular files can be unrolled from under %%PORTDOCS%%, but docs that are just docs should remain under %%PORTDOCS%%.

Also, since this PR was filed, DOCS was added to OPTIONS_DEFINE. Can you please update us on whether this is still an issue?
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2016-03-05 16:30:02 UTC 
This was fixed in ports r365165