Bug 191559 - [patch] print/cups-base-1.7.2_2 build fails if both AVAHI AND MDNSRESPONDER options are disabled
Summary: [patch] print/cups-base-1.7.2_2 build fails if both AVAHI AND MDNSRESPONDER o...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-02 13:28 UTC by ping1
Modified: 2014-07-02 14:24 UTC (History)
1 user (show)

See Also:


Attachments
proposed patch (546 bytes, text/x-csrc)
2014-07-02 13:28 UTC, ping1
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ping1 2014-07-02 13:28:27 UTC
Created attachment 144341 [details]
proposed patch

When compiling print/cups-base port with default options and both AVAHI and MDNSRESPONDER options disabled, the link fails because of undefined references:
/usr/ports/print/cups-base % make
[...]
Linking cupsfilter...
cc -L../cgi-bin -L../cups -L../filter -L../ppdc -L../scheduler -L/usr/local/lib -Wl,-rpath,/usr/lib:/usr/local/lib -Wl,-R/usr/local/lib   -Wall -Wno-format-y2k -Wunused -fPIC -Os -g -fstack-protector -Wno-tautological-compare -o cupsfilter cupsfilter.o -L. -lcupsmime -lcups  -lssl -lcrypto  -lz -pthread -lm -lcrypt   -lz
/bin/rm -f convert
/bin/ln -sf cupsfilter convert
dirsvc.o: In function `cupsdStartBrowsing':
/usr/ports/print/cups-base/work/cups-1.7.2/scheduler/dirsvc.c:244: undefined reference to `dnssdRegisterAllPrinters'
dirsvc.o: In function `cupsdStopBrowsing':
/usr/ports/print/cups-base/work/cups-1.7.2/scheduler/dirsvc.c:262: undefined reference to `dnssdDeregisterAllPrinters'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [cupsd] Error 1
gmake[3]: *** Waiting for unfinished jobs....
gmake[3]: Leaving directory `/usr/ports/print/cups-base/work/cups-1.7.2/scheduler'
gmake[2]: *** [all] Error 1
gmake[2]: Leaving directory `/usr/ports/print/cups-base/work/cups-1.7.2'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/print/cups-base
*** Error code 1

Stop.
make: stopped in /usr/ports/print/cups-base
/usr/ports/print/cups-base % 


Please find attached a small patch to fix this.
Note this is *not* a duplicate of bug#190865 since linker failures are not the same.
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2014-07-02 13:47:32 UTC
This should be fixed in 1.7.3 committed yesterday.  Can you confirm that it builds for you?
Comment 2 ping1 2014-07-02 14:24:29 UTC
(In reply to Jason E. Hale from comment #1)
> This should be fixed in 1.7.3 committed yesterday.  Can you confirm that it
> builds for you?

It does, thanks.