Created attachment 144375 [details] update bacula-web to 6.0.0 + add license + add more options for DB backend dependency
Over to maintainer.
Thanks. It may be a little while before I can test.
technically this timed out. Where does it stand?
I started testing last night and got stuck. I have yet to follow up on the advice: http://lists.freebsd.org/pipermail/freebsd-ports/2014-August/094510.html Code is no longer part of bacula.org, but part of web-bacula.org and they package their code differently.
Created attachment 145491 [details] use this patch Please use this patch, based on the original, but updated because things changed post-submission.
FYI: https://redports.org//~dvl/20140807225634-15296-231228/bacula-web-6.0.1.log
let's move it to "patch-ready"
Dan, I think there's copy-pasta in the Makefile changes in https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145491: .if ${PORT_OPTIONS:MPGSQL} USE_PGSQL= yes CONFIGURE_ARGS+= --with-postgresql=yes SUB_LIST+= REQ_PGSQL=postgresql USE_PHP+= pdo_sqlite .endif .if ${PORT_OPTIONS:MSQLITE} USE_PGSQL= yes CONFIGURE_ARGS+= --with-sqlite=yes SUB_LIST+= REQ_PGSQL=sqlite USE_PHP+= pdo_sqlite .endif The PGSQL processing has: > USE_PHP+= pdo_sqlite > ^^^^^^ And the SQLITE processing has: > USE_PGSQL= yes > ^^^^^ > SUB_LIST+= REQ_PGSQL=sqlite > ^^^^^
Created attachment 145529 [details] fixes DBO issues This should fix the PDO issues
One more, still has PGSQL references in the SQLITE processing: > .if ${PORT_OPTIONS:MSQLITE} > USE_PGSQL= yes > ^^^^^ > CONFIGURE_ARGS+= --with-sqlite=yes > SUB_LIST+= REQ_PGSQL=sqlite > ^^^^^ > USE_PHP+= pdo_sqlite > .endif
checking.
Created attachment 145535 [details] Fix bad options How is this?
That looks good to me. I applied the patch to svn head, rm'd files/patch*, and ran `env DEVELOPER=yes make stage && make check-plist && make package` which worked great. `make install` seems to be good, have yet to actually test the installed software.
Tested, works for me. Using with Bacula 5x on an SQLite database. Tested it on: FreeBSD angst.csh.rit.edu 10.0-STABLE FreeBSD 10.0-STABLE #9 r269194: Mon Jul 28 19:37:09 EDT 2014 antiduh@angst.csh.rit.edu:/usr/obj/usr/src/sys/ANGST64 amd64
Thank you for testing that. I don't use bacula-web at present.
hmm, I'm not seeing a good reason to override to "do-extract" target. I'm going to try to remove this target. It should still work fine.
I'm not sure what's going on with the pkg-plist either > cat pkg-plist @owner www @group www @owner @group What's the point of that? It looks like a no-op to me?
install target uses $CP -r, switching to COPYSHARE_TREE Can somebody explain why pkg-plist was switched to a dynamic plist? it's only 400 lines long originally.
i moved this back to a static PLIST, there was no justification for a dynamic one. I think the idea was that the BACULA_HOME was variable so it needed dynamic plist but this is false. I also installed files more discriminately than "copy everything" which included useless INSTALL and README files. so both do-extract and post-install targets have been removed now, and a full pkg-plist restored.
A commit references this bug: Author: marino Date: Sat Aug 9 13:38:44 UTC 2014 New revision: 364438 URL: http://svnweb.freebsd.org/changeset/ports/364438 Log: www/bacula-web: Upgrade version 1.38.9 => 6.0.1 PR: 191583 Submitted by: olevole (olevole.ru) Approved by: maintainer (dvl@) Lotsa TLC: marino@ Changes: head/www/bacula-web/Makefile head/www/bacula-web/distinfo head/www/bacula-web/files/patch-bacula-web-classes.inc head/www/bacula-web/files/patch-bacula-web-index.php head/www/bacula-web/files/patch-bacula-web-report.php head/www/bacula-web/files/patch-bacula-web-templates-full_popup.tpl head/www/bacula-web/files/patch-bacula-web-templates-index.tpl head/www/bacula-web/files/patch-bacula-web-templates-report.tpl head/www/bacula-web/files/patch-bacula-web-templates-volumes.tpl head/www/bacula-web/files/pkg-message.in head/www/bacula-web/pkg-descr head/www/bacula-web/pkg-plist
That took some time...
A commit references this bug: Author: marino Date: Sat Aug 9 13:54:08 UTC 2014 New revision: 364443 URL: http://svnweb.freebsd.org/changeset/ports/364443 Log: www/bacula-web: Fix pkg-message for non-default location installations I noticed in the commit diff that the pkg-message did not account for non-default values of BACULAWEB_HOME, but rather assumed the equivalent of %%WWWDIR%% (and didn't even use that!). Add a new substition so that the pkg-message message is correct for non-default locations. PR: 191583 Changes: head/www/bacula-web/Makefile head/www/bacula-web/files/pkg-message.in
I've noticed a line in Makefile: CATEGORIES= sysutils www is it really needed? Why it try to update soft from ports tree it makes portmaster to say root@timbsd:/usr/ports/www/bacula-web # portmaster -da ===>>> Gathering distinfo list for installed ports ===>>> Starting check of installed ports for available updates ===>>> No /usr/ports/sysutils/bacula-web exists, and no information ===>>> about sysutils/bacula-web can be found in /usr/ports/MOVED ===>>> All ports are up to date
(In reply to timp87 from comment #23) > I've noticed a line in Makefile: > CATEGORIES= sysutils www > > is it really needed? It's backwards, it should be www sysutils. I don't know understand the urge to put things in more than one category myself. But I need to fix this.
A commit references this bug: Author: marino Date: Sun Aug 10 07:20:25 UTC 2014 New revision: 364506 URL: http://svnweb.freebsd.org/changeset/ports/364506 Log: Reverse categories in www/baculaweb for portmaster and friends Nobody noticed that the submitter added a new category to the port and kept it in alphabetical order rather than "true" category first, so we need to move "www" back to the front of the line. PR: 191583 Changes: head/www/bacula-web/Makefile